Redmine

It's a beta, are you sure it's not a browser issue ?

Etienne Massip wrote:

It's a beta,

Yes.
But "37.0.2042.0 canary" has same problem.
http://www.chromium.org/getting-involved/download-chromium

are you sure it's not a browser issue ?

• Firefox 29.0.1
• Chrome 35.0.1916.153 m
• IE 11.0.9699.17107

I can confirm this bug on 38.0.2066.5 canary too, and a Planio customer observed this issue on Chrome 36.0.1985.84 too.

I think this is a browser issue though as both browsers make 2 requests to upload.js with 2 different attachment_id (1 and 2 in my and the customers tests).

I have confirmed this patch fixes in google-chrome-beta-36.0.1985.84-1 on Fedora 20.

If this is a beta browser version issue, then why not fix browser instead??

The issue is indeed in the js code, but as it is somewhat of a corner case it didn't create a problem until now.

Furthermore, following this logic you would need to remove all IE or other browser-specific hacks :-)

Felix Schäfer wrote:

Furthermore, following this logic you would need to remove all IE or other browser-specific hacks :-)

You don't get it, this fix is for a beta version, this is nonsense if the bug is indeed in the browser and not in jq or ror.

Could we wait for the 36 release to make sure it affects it too before committing it, eventually report the issue to chrome project?

Etienne Massip wrote:

If this is a beta browser version issue, then why not fix browser instead??

Chrome 36, 37 and 38 have this problem.
Chrome and Chromium version policy is not clear.
I am afraid Chrome and Chromium team will refuse bug fix of Chrome 36.
Such as Rails team refused bug fix of Rails 3.2.

What if it has already been fixed in 36 release?

Such as Rails team refused bug fix of Rails 3.2.

http://goo.gl/1G4olw

I have created chromium ticket.
http://goo.gl/FjMZtS

Thanks!

Chrome 36 is out and the regression hasn't been merged so it's buggy til 37 comes.

That would be great to add a comment to explain that this commit is due to regression and can be reverted when 37 is out.

Works for me.

Redmine: 2.5.1.stable
Google Chrome: 36.0.1985.125

Toshi MARUYAMA wrote:

Chrome/Chromium version policy is not clear.
So, I committed trunk r13199, 2.5-stable r13201 and 2.4-stable r13203.

Rafał Lisowski wrote:

Redmine: 2.5.1.stable
Google Chrome: 36.0.1985.125

Not works for me.

Gennady Grechin wrote:

Rafał Lisowski wrote:

Redmine: 2.5.1.stable
Google Chrome: 36.0.1985.125

Not works for me.

Because r13201 is in 2.5.2, not in 2.5.1.
2.5.2 includes 2.4.6 fixes.

Pierre Pretorius wrote:

The patch for 2.4 and 2.5 doesn't work in 2.3. Attached is the patch for 2.3. It modifies attachments.js to remove the onchange before cloning the input box, then it adds it to the cloned box afterwards.

Thank you very much Pierre, your patch file for 2.3 solved the problem within my 2.3.4.stable.12746.

Quick question.. on the 2.3 patch, does views/attachements/_form.html.erb need updated as well or just the javescript part?

Cheyenne Wills wrote:

Quick question.. on the 2.3 patch, does views/attachements/_form.html.erb need updated as well or just the javescript part?

I patched only the javascipt file with the command:

patch attachments.js < 17151_redmine_2.3_latest.patch

Thank you

I'm running Redmine 2.5.1 and started having that problem with the latest Chrome update, version 36.0.1985.125 m. Is it fixed in 2.5.2? Is there a patch for 2.5.1?

Vinicius Ferreira wrote:

Is it fixed in 2.5.2?

Yes.

2.5.2 includes 2.4.6 fixes.

I'm also running Redmine 2.5.1 is there any patch for it? Or can I use the attachments.js and _form.html.erb from 2.5.2 in 2.5.1 to fix this bug?

red dot wrote:

I'm also running Redmine 2.5.1 is there any patch for it?

http://www.redmine.org/projects/redmine/repository/revisions/13201/diff?format=diff

Hi guys, firstly, thank you by your effort on fixing it!

I'm using a BitNami package - 2.5.2 and I've just migrate from 2.4.1 and I would like to share with you guys that I had to run the following commands on MySQL, in order to run 2.5.2 correctly (it was need due my customized fields ;)

use bitnami_redmine

ALTER TABLE custom_fields ADD format_store TEXT(65535);
ALTER TABLE custom_fields ADD description TEXT(65535);

Tks again!
Fernando Sampaio

Toshi MARUYAMA wrote:

red dot wrote:

I'm also running Redmine 2.5.1 is there any patch for it?

http://www.redmine.org/projects/redmine/repository/revisions/13201/diff?format=diff

How to use it? - solved

I'm use it, and it's not solve my problem.
I have same ussue like in top screen on 2.5.1.

seyfer seed wrote:

Toshi MARUYAMA wrote:

red dot wrote:

I'm also running Redmine 2.5.1 is there any patch for it?

http://www.redmine.org/projects/redmine/repository/revisions/13201/diff?format=diff

How to use it? - solved

I'm use it, and it's not solve my problem.
I have same ussue like in top screen on 2.5.1.

Why not update to 2.5.2?

seyfer seed wrote:

Toshi MARUYAMA wrote:

red dot wrote:

I'm also running Redmine 2.5.1 is there any patch for it?

http://www.redmine.org/projects/redmine/repository/revisions/13201/diff?format=diff

How to use it? - solved

How do you apply?

Toshi MARUYAMA wrote:

Vinicius Ferreira wrote:

Is it fixed in 2.5.2?

Yes.

2.5.2 includes 2.4.6 fixes.

Hi, I still encounter the same problem in 2.5.2.stable.
Any advice?

chu chu wrote:

Hi, I still encounter the same problem in 2.5.2.stable.

How do you check your version is 2.5.2?

http://goo.gl/htEwxs

This issue should be fixed by 36.0.1985.143, which was pushed to stable channel yesterday.

Toshi MARUYAMA wrote:

http://goo.gl/htEwxs

This issue should be fixed by 36.0.1985.143, which was pushed to stable channel yesterday.

It works well now,
thank you!