Defect #17581
closed
Drag & Drop does not work with Safari 5.1
0%
Related issues
Updated by Toshi MARUYAMA over 10 years ago
- Category set to Attachments
- Target version set to 2.4.7
Updated by Toshi MARUYAMA over 10 years ago
- Related to Defect #13932: File upload does not work with Safari added
Updated by Etienne Massip about 10 years ago
Why remove the 'FileReader' in window test?
Updated by Toshi MARUYAMA about 10 years ago
Etienne Massip wrote:
Why remove the
'FileReader' in windowtest?
fred, could you give us the answer?
Updated by fred bregar about 10 years ago
FileReader is not needed. (Search repo for FileReader)
Checking for FileReader was simply a hack for Safari 5.1 to return false. FileReader is for actually reading a file in a browser (like dragging a text file into the browser and creating a <textarea> tag and displaying contents of the file). Redmine is not reading the contents of the File, just uploading it.
a better test would be:
if ($.ajaxSettings.xhr().upload && inputEl.files)
//but this instantiates a new XMLHttpRequest object and does nothing with it.
but like i said (#13932-13) the real problem is jQuery. jQuery was amazing, but unless you need to support IE8 and below there is really no need for it these days.
Updated by Toshi MARUYAMA about 10 years ago
- Status changed from New to Closed
- Resolution set to Fixed
Committed in trunk, 2.5-stable and 2.4-stable, thanks.