Actions
Feature #20388
closedRemoving attachment after commit transaction
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Description
Now in Attachment model is
after_destroy :delete_from_disk
If you want to construct a serious logic with Rollback this behaviour leads to remove file from disk, but leave an attachment record in DB.
In my project I replaced this callback on
after_commit :delete_from_disk, on: :destroy
and it works perfect.
I think this is a good modification for Redmine. It have full backward compatibility but can extend ability for strong logic in app.
Updated by Ivan Zabrovskiy over 9 years ago
Notice: in Rails 4 appear new config option related with transaction callbacks:
config.active_record.raise_in_transactional_callbacks = trueIt allows to propagate errors from transaction callbacks. Preferable to turn it on.
Updated by Jean-Philippe Lang about 9 years ago
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
- Resolution set to Fixed
Change committed in r14630, thanks.
Actions