Project

General

Profile

Actions
Copy link

Patch #21611

closed

Do not collect ids of subtree in Query#project_statement

Added by Ondřej Ezr almost 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Code cleanup/refactoring
Target version:
3.3.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

It is inefficient in larger subtree - it would be nicer with pluck, but it would still result in ugly queries with more projects.
Best way is to use subquery in that cases

Files

Download all files
query_project_statement.diff (1.41 KB) query_project_statement.diff use query not pluck ids Ondřej Ezr, 2015-12-27 19:07
query_project_statement_2.diff (1.5 KB) query_project_statement_2.diff v2 Ondřej Ezr, 2016-01-03 19:45

Related issues

Related to Redmine - Defect #19976: Redmine can't work with 3000 projectsNeeds feedback

Actions
Related to Redmine - Feature #19102: Redmine doesnt scale with large amount of projectsClosed

Actions
Actions
Copy link
 #1

Updated by Go MAEDA almost 9 years ago

  • Target version set to Candidate for next major release

According to #21608#note-3, this patch will resolve #19976 and #19102.

Actions
Copy link
 #2

Updated by Go MAEDA almost 9 years ago

  • Related to Defect #19976: Redmine can't work with 3000 projects added
Actions
Copy link
 #3

Updated by Go MAEDA almost 9 years ago

  • Related to Feature #19102: Redmine doesnt scale with large amount of projects added
Actions
Copy link
 #4

Updated by Jean-Philippe Lang almost 9 years ago

The patch breaks a few tests. It displays issues from subpprojects even if display_subprojects_issues setting is disabled.

Actions
Copy link
 #5

Updated by Ondřej Ezr almost 9 years ago

I see... I frogot one case in the statement.

Actions
Copy link
 #6

Updated by Go MAEDA almost 9 years ago

Thanks for updating the patch. It have passed all tests.

Actions
Copy link
 #7

Updated by Toshi MARUYAMA almost 9 years ago

  • Target version changed from Candidate for next major release to 3.3.0
Actions
Copy link
 #8

Updated by Jean-Philippe Lang almost 9 years ago

  • Subject changed from Query project_statement - do not collect ids of subtree. to Do not collect ids of subtree in Query#project_statement
  • Category set to Code cleanup/refactoring
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Committed, thanks!

Actions
Copy link

Also available in: Atom PDF