Project

General

Profile

Actions
Copy link

Defect #21674

closed

The LDAP connection test does not check the credentials

Added by Helder Manuel Torres Vieira almost 9 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
LDAP
Target version:
3.3.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Defect Description

In the current version and the last trunk, the Authenticacion Modes that works through LDAP does not check the username or password.

This can be a problem, because, if the LDAP Server is available but does not return any response due to an incorrect username and password, and can't bind the connection.

This patch adds the possibility in the moment to do a LDAP connection Test, if the username and password is defined it binds to check that are correct, else returns an exception with it's error.

I've added the follow test to check the username and the password, as the connectivity against the LDAP Server.

This patch has been tested with the last Trunk (14992) and the configurations of the LDAP Server that comes included to do the tests.

Running Tests:

vagrant@redmine:/opt/redmine/trunk# RAILS_ENV="test" rake test test/unit/auth_source_ldap_test.rb
Run options: --seed 12217

# Running:

.......................

Finished in 3.987555s, 5.7679 runs/s, 20.0624 assertions/s.

23 runs, 80 assertions, 0 failures, 0 errors, 0 skips
vagrant@redmine:/opt/redmine/trunk#

Attached Screenshots:

Auth Sources

Change LDAP Username/Password

Display Error

Files

Download all files
2.png (58.7 KB) 2.png Display Error Helder Manuel Torres Vieira, 2016-01-08 12:15
1.png (63 KB) 1.png Change LDAP Username/Password Helder Manuel Torres Vieira, 2016-01-08 12:15
0.png (56.9 KB) 0.png Auth Sources Helder Manuel Torres Vieira, 2016-01-08 12:15
ldap_test_bind_user_password.diff (27.3 KB) ldap_test_bind_user_password.diff Patch Helder Manuel Torres Vieira, 2016-01-08 12:16
Actions
Copy link
 #1

Updated by Toshi MARUYAMA almost 9 years ago

  • Target version set to 3.3.0
Actions
Copy link
 #2

Updated by Jean-Philippe Lang almost 9 years ago

  • Subject changed from LDAP does not check the user and password when are defined in the method of authentication. to LDAP does not check the user and password that are defined in the method of authentication
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Patch committed, thanks.

Actions
Copy link
 #3

Updated by Jean-Philippe Lang over 8 years ago

  • Subject changed from LDAP does not check the user and password that are defined in the method of authentication to The LDAP connection test does not check the credentials
Actions
Copy link

Also available in: Atom PDF