Feature #22058: Show image attachments and repo entries instead of downloading them - Redmine

Actions

Feature #22058

closed

Show image attachments and repo entries instead of downloading them

Added by Jan from Planio www.plan.io almost 9 years ago. Updated over 7 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Jean-Philippe Lang

Category:

Attachments

Target version:

Start date:

Due date:

% Done:

0%

Estimated time:

Resolution:

Fixed

Description

For text file attachments and text files in a repository, we have a nice inline display in Redmine that even shows line numbers.

Images however are always just downloaded. It would be nice if they were displayed as well.

Files

Download all files

Patch #21847_ Let mobile header be fixed - Redmine 2016-02-17 16-39-27.png (115 KB) Patch #21847_ Let mobile header be fixed - Redmine 2016-02-17 16-39-27.png		Jan from Planio www.plan.io, 2016-02-17 10:40
0001-Reduce-view-code-duplication-by-using-a-nested-layou.patch (3.32 KB) 0001-Reduce-view-code-duplication-by-using-a-nested-layou.patch		Jan from Planio www.plan.io, 2016-02-17 10:47
0002-Whitespace-only-change.patch (2.14 KB) 0002-Whitespace-only-change.patch		Jan from Planio www.plan.io, 2016-02-17 10:47
image_preview_in_redmine.jpg (370 KB) image_preview_in_redmine.jpg		Jan from Planio www.plan.io, 2016-02-17 10:47
0004-Whitespace-only.patch (949 Bytes) 0004-Whitespace-only.patch		Jan from Planio www.plan.io, 2016-02-17 10:47
0003-Add-inline-image-preview-display-for-attachments-and.patch (4.97 KB) 0003-Add-inline-image-preview-display-for-attachments-and.patch		Jan from Planio www.plan.io, 2016-04-11 14:03

Actions

#1

Updated by Jan from Planio www.plan.io almost 9 years ago

Description updated (diff)

Actions

#2

Updated by Jan from Planio www.plan.io almost 9 years ago

File image_preview_in_redmine.jpg image_preview_in_redmine.jpg added
File 0001-Reduce-view-code-duplication-by-using-a-nested-layou.patch 0001-Reduce-view-code-duplication-by-using-a-nested-layou.patch added
File 0002-Whitespace-only-change.patch 0002-Whitespace-only-change.patch added
File 0003-Add-inline-image-preview-display-for-attachments-and.patch added
File 0004-Whitespace-only.patch 0004-Whitespace-only.patch added
Assignee deleted (~~Jan from Planio www.plan.io~~)
Target version set to Candidate for next minor release

Here's a patch series that adds this feature:

Actions

#3

Updated by Jan from Planio www.plan.io over 8 years ago

File deleted (~~0003-Add-inline-image-preview-display-for-attachments-and.patch~~)

Actions

#4

Updated by Jan from Planio www.plan.io over 8 years ago

File 0003-Add-inline-image-preview-display-for-attachments-and.patch 0003-Add-inline-image-preview-display-for-attachments-and.patch added

Rebasing patch onto current trunk.

Actions

#5

Updated by Go MAEDA over 8 years ago

Target version changed from Candidate for next minor release to 3.3.0

Actions

#6

Updated by Jean-Philippe Lang over 8 years ago

Status changed from New to Closed
Assignee set to Jean-Philippe Lang
Resolution set to Fixed

Actions

#7

Updated by Krzysztof Zielonka over 7 years ago

Is any reason to use download_named_attachment_url in app/views/attachments/image.html.erb instead download_named_attachment_path?

Actions

#8

Updated by Toshi MARUYAMA over 7 years ago

Krzysztof Zielonka wrote:

Is any reason to use download_named_attachment_url in app/views/attachments/image.html.erb instead download_named_attachment_path?

Actions

Also available in: Atom PDF