Project

General

Profile

Actions
Copy link

Patch #23519

closed

Don't preload projects and roles on Principal#memberships association

Added by Ondřej Ezr over 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Performance
Target version:
3.4.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Why it should preload project and roles by default? it is not used over the redmine much, and somewhare it is not good to preloading those associations.

Files

Download all files
memberships_performance.diff (3.42 KB) memberships_performance.diff Ondřej Ezr, 2016-08-05 17:50
memberships_performance.diff (3.13 KB) memberships_performance.diff v2 - no reason to use preload for one entity Ondřej Ezr, 2016-08-12 17:15
Actions
Copy link
 #1

Updated by Ondřej Ezr over 8 years ago

No reason for preload in membership(...)

Actions
Copy link
 #2

Updated by Toshi MARUYAMA about 8 years ago

  • Target version set to 3.4.0
Actions
Copy link
 #3

Updated by Jean-Philippe Lang almost 8 years ago

  • Subject changed from Performance for memberships to Don't preload projects and roles on Principal#memberships association
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Patch committed, thanks. FTR, the proposed patch was not working as expected and broke a few tests, #roles has to be called explicitly (using self.roles) due to a variable naming clash in #allowed_to?.

Actions
Copy link

Also available in: Atom PDF