Project

General

Profile

Actions
Copy link

Patch #25022

closed

Add an index on attachments.disk_filename

Added by Jens Krämer almost 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Performance
Target version:
3.4.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

In a system with lots of attachments deleting one attachment can take very long due to the DB lookup in Attachment#delete_from_disk which checks if the same physical file is used by any other attachment.

We had this issue at Planio in a setup with more than 500k attachments, where deleting a single one could take up to half a second. This patch adds an index on attachments.disk_filename that fixed the issue for us.

Files

0001-adds-an-index-to-attachments.disk_filename.patch (1.01 KB) 0001-adds-an-index-to-attachments.disk_filename.patch Jens Krämer, 2017-02-07 08:20
Actions
Copy link
 #1

Updated by Go MAEDA almost 8 years ago

  • Category set to Performance
  • Target version set to 3.4.0

Thanks for sharing the experience and the patch.
Setting target version to 3.4.0.

Attachment#delete_from_disk: source:tags/3.3.2/app/models/attachment.rb#L145

Actions
Copy link
 #2

Updated by Jean-Philippe Lang almost 8 years ago

  • Subject changed from add an index on attachments.disk_filename to Add an index on attachments.disk_filename
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

That should be usefull indeed, thanks.

Actions
Copy link

Also available in: Atom PDF