Feature #25999
closed
View repository content by default (instead of the history)
0%
Description
In line with the changes proposed in #25988, I'd like to propose to change the default behaviour for clicking on entries in the repository to showing the entry's contents, rather than it's history. The research we did at Planio showed that viewing is the more common action. GitHub and Bitbucket use the same behaviour, by the way.
This patch series also introduces the existing 2nd level tab style for the "View", "History", and "Annotate" links on repo entries and adds the download icon introduced in #25988 to the download links to make them a little more prominent.
Here's a screenshot:
Files
Related issues
Updated by Jan from Planio www.plan.io over 7 years ago
- Blocked by Feature #25988: Preview files by default instead of downloading them added
Updated by Jan from Planio www.plan.io over 7 years ago
- Description updated (diff)
Updated by Go MAEDA over 7 years ago
Jan from Planio www.plan.io wrote:
I'd like to propose to change the default behaviour for clicking on entries in the repository to showing the entry's contents, rather than it's history. The research we did at Planio showed that viewing is the more common action.
Absolutely agree. To be honest, it was frustrating for me to click a lot to see source codes. I am sure that the patch can greatly improves UX of Redmine.
Updated by Go MAEDA over 7 years ago
I think it would be even better to change link destination of the breadcrumbs too.
diff --git a/app/views/repositories/_breadcrumbs.html.erb b/app/views/repositories/_breadcrumbs.html.erb
index eb115f9ad..82f25d43a 100644
--- a/app/views/repositories/_breadcrumbs.html.erb
+++ b/app/views/repositories/_breadcrumbs.html.erb
@@ -18,7 +18,7 @@ dirs.each do |dir|
<% end %>
<% if filename %>
/ <%= link_to filename,
- :action => 'changes', :id => @project, :repository_id => @repository.identifier_param,
+ :action => 'entry', :id => @project, :repository_id => @repository.identifier_param,
:path => to_path_param("#{link_path}/#{filename}"), :rev => @rev %>
<% end %>
<%
![[proposal] change link destination of breadcrumbs](/attachments/download/18359/repo-browser-breadcrumbs@2x.png "[proposal] change link destination of breadcrumbs")
Updated by
Updated by Go MAEDA over 7 years ago
- Related to Feature #25357: "Raw view" of a file in repository added
Updated by Go MAEDA over 7 years ago
- Related to Feature #14332: [Repository] Make "view file" the default added
Updated by Go MAEDA over 7 years ago
- Target version changed from Candidate for next minor release to 3.4.0
This is a great improvement. Setting target version to 3.4.0.
Updated by Jan from Planio www.plan.io over 7 years ago
Go MAEDA wrote:
I think it would be even better to change link destination of the breadcrumbs too.
Thank you for improving my patch! I totally agree.
Updated by Jan from Planio www.plan.io over 7 years ago
- File deleted (
0001-Make-View-the-default-action-for-repository-entries-.patch)
Updated by Jan from Planio www.plan.io over 7 years ago
- File 0001-Make-View-the-default-action-for-repository-entries-.patch 0001-Make-View-the-default-action-for-repository-entries-.patch added
Please find attached updated patch 0001. It now contains the changes suggested by Go.
Updated by Jan from Planio www.plan.io over 7 years ago
- Blocks Feature #26035: More visually consistent download links added
Updated by Mischa The Evil over 7 years ago
Jan from Planio www.plan.io wrote:
In line with the changes proposed in #25988, I'd like to propose to change the default behaviour for clicking on entries in the repository to showing the entry's contents, rather than it's history. The research we did at Planio showed that viewing is the more common action. GitHub and Bitbucket use the same behaviour, by the way.
I agree. This could really reduce the required number of clicks to get to the content (which is IMHO indeed a valid drawback of the current implementation).
Updated by Jean-Philippe Lang over 7 years ago
- Blocked by deleted (Feature #25988: Preview files by default instead of downloading them)
Updated by Jean-Philippe Lang over 7 years ago
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
- Resolution set to Fixed
Patches are committed, thanks.