Defect #26880: Cannot clear all watchers when copying an issue - Redmine

Actions

Copy link

Defect #26880

closed

Cannot clear all watchers when copying an issue

Added by Go MAEDA about 7 years ago. Updated almost 7 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Jean-Philippe Lang

Category:

Issues

Target version:

3.4.4

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

3.4.2

Description

We can select/deselect watchers when we create an issue by copying existing issue (#10460).

But if you deselect all watchers, the original watchers are preselected in the newly created issue despite the exception that the copied issue has no watcher.

Steps to reproduce:

1. The original issue has 2 watchers.

2. Click "Copy" and deselect all watcher.

3. The newly created issue should not have any watchers but all watchers are preserved.

Files

Download all files

01-copy-source@2x.png (68.6 KB) 01-copy-source@2x.png		Go MAEDA, 2017-09-11 04:37
02-deselect-watchers@2x.png (52.3 KB) 02-deselect-watchers@2x.png		Go MAEDA, 2017-09-11 04:37
03-watchers-are-preserved@2x.png (67.8 KB) 03-watchers-are-preserved@2x.png		Go MAEDA, 2017-09-11 04:37
fix_26880.patch (2.08 KB) fix_26880.patch		Takenori TAKAKI, 2017-12-01 09:41

Related issues

Actions

Copy link

Updated by Go MAEDA about 7 years ago

Related to Feature #10460: Option to copy watchers when copying issues added

Actions

Copy link

Updated by Tibor Kreiter about 7 years ago

Hi Go MAEDA!

You have to change this row in app/controllers/issue_controller:

 row:493      - @copy_watchers = User.current.allowed_to?(:add_issue_watchers, @project)
              + @copy_watchers = params[:copy_watchers].present?  || request.get?

I think it will be solve your problem.
Tibor

Actions

Copy link