Project

General

Profile

Actions
Copy link

Patch #27139

closed

Fix for project link background in calendar tooltips

Added by Bernhard Rohloff about 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Calendar
Target version:
3.3.6
Start date:
Due date:
% Done:

0%

Estimated time:

Description

The project link in the calendar tooltip shows the same background image (starting, ending) as the related issue number.
The patch adds a :first-child selector in the default application.css file.

Before patch:

After patch:

Files

Download all files
calendar_tooltip_issue.png (9.31 KB) calendar_tooltip_issue.png Bernhard Rohloff, 2017-10-08 11:15
calendar_tooltip_fixed.png (9.62 KB) calendar_tooltip_fixed.png Bernhard Rohloff, 2017-10-08 11:15
calendar_tooltip_fix_project_background.diff (1.24 KB) calendar_tooltip_fix_project_background.diff Bernhard Rohloff, 2017-10-08 11:20
calendar_tooltip_fix_suggested_by_marius.diff (1.28 KB) calendar_tooltip_fix_suggested_by_marius.diff The new fix with the 'table.cal .starting a.issue' selector Bernhard Rohloff, 2017-11-27 06:43
Actions
Copy link
 #1

Updated by Mischa The Evil about 7 years ago

  • Target version set to Unplanned backlogs
Actions
Copy link
 #2

Updated by Go MAEDA almost 7 years ago

  • Target version changed from Unplanned backlogs to 3.3.6

I think there is no problem to include this small UI fix in the next minor release. Setting target version to 3.3.6.

Actions
Copy link
 #3

Updated by Marius BĂLTEANU almost 7 years ago

I think that it is more safe to target directly the issue using table.cal .starting a.issue instead of the :first-child.

Actions
Copy link
 #4

Updated by Bernhard Rohloff almost 7 years ago

Yes, I agree. Marius' approach is much cleaner. Thank you!
I've made another patch with the changes suggested by him.

Actions
Copy link
 #5

Updated by Go MAEDA almost 7 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed in the trunk and merged to stable branches.
Thank you for fixing this issue and thank Marius for reviewing the patch.

Actions
Copy link

Also available in: Atom PDF