Defect #3112: Bug in spent time report - the start date isn't included - Redmine

Actions

Copy link

Defect #3112

closed

Bug in spent time report - the start date isn't included

Added by Anonymous over 15 years ago. Updated about 15 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

Time tracking

Target version:

0.8.7

Start date:

2009-04-03

Due date:

% Done:

100%

Estimated time:

Resolution:

Fixed

Affected version:

0.8.2

Description

I've just been checking spent time reports for this week. I've logged time on both 2009-04-01 and 2009-04-02 but if I ask for a report from these days, the report displays the column for 2009-04-01 but doesn't display any values in it. If I change the start date to 2009-03-31 then suddenly the values appear. See the attached images which show this. In image 1, no values are listed under 2009-04-01 but in the second image the correct values are listed.

Redmine-0.8.2
sqlite-3.5.9
ruby-1.8.6 on win32
rails-2.1.2

Files

Download all files

Image1.PNG (17.8 KB) Image1.PNG		Anonymous, 2009-04-03 09:23
Image2.PNG (29.1 KB) Image2.PNG		Anonymous, 2009-04-03 09:23
before.PNG (46.4 KB) before.PNG	Missing values for the 4th May	Brad Rushworth, 2009-05-11 02:30
after.PNG (46.4 KB) after.PNG	Values appear for the 4th May	Brad Rushworth, 2009-05-11 02:30

Actions

Copy link

Updated by Brad Rushworth over 15 years ago

File before.PNG before.PNG added
File after.PNG after.PNG added

I'm experiencing the same problem on Redmine 0.8.2.stable (SQLite).

Using the "last 7 days" drop down option has the same behaviour.

I assume this has something to do with converting the date "2009-05-04" into the correct datetime "2009-05-04 00:00:00".

In fact, this bug is better shown by selecting "today" or setting the 'from' and 'to' fields to the same day. No data is shown. However, move the 'from' date back a day and you get todays data but not yesterdays.

I narrowed it down to here:
source:tags/0.8.2/app/controllers/timelog_controller.rb
Lines 91 and 158 show:
['spent_on BETWEEN ? AND ?', @from, tO tO]

Clearly this isn't going to show all data from today, if @from and tO tO are the same value.

Perhaps we could add a line near L285 saying:
@from = @from - 1

My knowledge of Ruby programming is quite limited, so I welcome any suggestions.

Actions

Copy link

Updated by Anonymous about 15 years ago

Category set to Time tracking

Is there any chance this could be fixed at some point? We have to tie up time reports from Redmine with our companie's time-tracking system. Having to remember to subtract '1' from the from date isn't always done which makes the tying up inaccurate.

Thanks

Russell

Actions

Copy link