Project

General

Profile

Actions
Copy link

Defect #5452

closed

Member role forms in project settings are not hidden after member added

Added by Yuki Kita over 14 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Eric Davis
Category:
UI
Target version:
0.9.5
Start date:
2010-05-06
Due date:
% Done:

100%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Member role forms in project settings should be hidden by default.
And we click [edit] button to see them.
But if I add some member to a project, all member role forms are shown.
So I have to click [cancel] button one by one to hide them.

It seems that the behavior was changed after the fix for #4852 ( r3483 ).
Because the load event handler bellow is not called after member added.

Event.observe(window, 'load', function() {
  $$('.hol').each(function(el) {
      el.hide();
    });
});

Files

Download all files
_members.rhtml.diff (1.12 KB) _members.rhtml.diff Alain Alain091, 2010-05-07 23:06
application.js.diff (375 Bytes) application.js.diff Alain Alain091, 2010-05-07 23:07
member_role_forms.patch (3.23 KB) member_role_forms.patch Yuki Kita, 2010-05-08 02:53
member_role_forms2.patch (2.77 KB) member_role_forms2.patch Yuki Kita, 2010-05-11 14:38
Actions
Copy link
 #1

Updated by Felix Schäfer over 14 years ago

  • Category set to UI
  • Target version set to 0.9.5

I have also had that problem on at least one of my installations. I'll try to go through all of them and post the version numbers.

Actions
Copy link
 #2

Updated by Alain Alain091 over 14 years ago

See patches attached for application.js and _members.rhtml

The name of the function hideRoles could be change if not appropriate.

Actions
Copy link
 #3

Updated by Alain Alain091 over 14 years ago

The other file

Actions
Copy link
 #4

Updated by Yuki Kita over 14 years ago

Alain Gandon wrote:

See patches attached for application.js and _members.rhtml

The name of the function hideRoles could be change if not appropriate.

Thanks for your cooperation.
The patch works fine.
But I noticed that there still remains some code to be fixed.
So I updated your patch.

Actions
Copy link
 #5

Updated by Yuki Kita over 14 years ago

But I noticed that there still remains some code to be fixed.

Member role forms are shown not only after member added, but also after member deleted and member role changed.

Actions
Copy link
 #6

Updated by Yuki Kita over 14 years ago

Updated the patch to reflect the current trunk.

Actions
Copy link
 #7

Updated by Eric Davis over 14 years ago

  • Status changed from New to Resolved
  • Assignee set to Eric Davis
  • % Done changed from 0 to 100
  • Resolution set to Fixed

Fixed in r3784. I did it a little differently and had the RJS in the MembersController send hideOnLoad() to the page itself. Thank you for the contribution.

Actions
Copy link
 #8

Updated by Eric Davis over 14 years ago

  • Status changed from Resolved to Closed

Merged to 0.9-stable for release.

Actions
Copy link

Also available in: Atom PDF