Redmine

Hum, apparently I can't add related issues. They should be:
#5438
#6968

Hi Eli,

And thanks for your patch. Worked fine for me. I'll post here in case this breaks some use cases.
Hope this change will be made available in the next release.

Regards,
Guillaume

Update: the first line didn't work in all cases for me. This one seems to be behaving better:

[(x.root.start_date or x.start_date or Date.new()), x.root_id, (x.start_date or Date.new()), x.lft] <=> [(y.root.start_date or y.start_date or Date.new()), y.root_id, (y.start_date or Date.new()), y.lft]

Hi,
where do I enter this line of code or apply this patch?

Thanks,
Sebastian

lib/redmine/helpers/gantt_helper.rb (gantt_issue_compare()) ?

thanks. Works fine.

Anyone knows if we can also sort by name? Or if the above patch could be easily modified to sort by top level issue name (instead of id like current or start date like this fix)?
feel free to move this to a new issue if you feel it's necessary.

+1

thanks. Works fine.

+1

+1, related with #8480

+1

FTR the patch in #7456 originally implemented some sorting too.

Hi guys.

I just required the sort by start date and then applied manually the first chunk mentioned on sort_issues_from_start_date.diff, to my 2.2.0 version, and it worked as expected.

So, could it be possible to apply it on 2.2's trunk or next versions? I see that a default sorting by start_date first has more sense than by issue_id.

Thanks in advance.

New patch is posted at #8366#note-2.

Thank you for your patch, Toshi.

I applied your patch, and it looked working correctly, first.
However, note-16 problem is still happen to issues which added
after your patch applied.

I tried gantt-sort-trunk-r11740.diff, and it seems working correctly!
Thank you !!

Regards,
Yuhki ISHIGURO

Toshi MARUYAMA wrote:

gantt-sort-trunk-r11740.diff does not sort root issues.
This patch fixes it.

I greatly appreciate for you contribution.
I tried your new patch gantt-sort-trunk-r11744.
It works fine, and I think it solves this issue.

Regards,
Yuhki ISHIGURO

Hi,

I tried to apply patch but errors occured :

root@linus:/var/www/redmine# patch -p0 < gantt-sort-trunk-r11744.diff
patching file b/lib/redmine/helpers/gantt.rb
Hunk #1 FAILED at 675.
1 out of 1 hunk FAILED -- saving rejects to file b/lib/redmine/helpers/gantt.rb.rej
patching file b/lib/redmine/helpers/gantt.rb
Hunk #1 FAILED at 687.
1 out of 1 hunk FAILED -- saving rejects to file b/lib/redmine/helpers/gantt.rb.rej
patching file b/lib/redmine/helpers/gantt.rb
Hunk #1 FAILED at 686.
1 out of 1 hunk FAILED -- saving rejects to file b/lib/redmine/helpers/gantt.rb.rej
patching file b/lib/redmine/helpers/gantt.rb
Hunk #1 FAILED at 220.
Hunk #2 FAILED at 694.
2 out of 2 hunks FAILED -- saving rejects to file b/lib/redmine/helpers/gantt.rb.rej

Some help please ?

Thanks.

Version Info :

Environment:
Redmine version 2.3.0.devel.11744
Ruby version 1.8.7 (x86_64-linux)
Rails version 3.2.13
Environment production
Database adapter MySQL
Redmine plugins:
due_date_reminder 0.3.1

David Dupont wrote:

Some help please ?

Use -p1 instead of -p0.

patch -p1 < gantt-sort-trunk-r11744.diff

And this patch is for trunk r11744, not 2.3.0.

Thanks for the answer !

So i can't install it ?

Even if i change the file manually ? Is there too many difference between the trunk and 2.3.0 ?

David Dupont wrote:

Is there too many difference between the trunk and 2.3.0 ?

There is no difference between trunk r11768 and 2.3-stable r11769 for this patch.
You can apply this patch to 2.3-stable.

Filou Centrinov wrote:

Please correct sort_version_logic(). Only "version.effective_date" contains the start date of a version. Otherwise the versions won't sorted by start date as expected.

A better option would be to sort versions by version.effective_date || version.start_date. A version may not have an effective_date but some issues with start dates assigned to it.

Versions with no start_date nor effective should be listed at the very end. I'm not this is the case with || Date.new.

If it can help, here's an excerpt from #7456 where the idea was also to display shared version before concerned projects:

The shared version is tied to the selected project (also valid for "all projects" Gantt):

parent project -> shared version -> subproject -> shared version issues (including parent project issues)

The shared version is tied to a not-visible-parent project of the selected project:

subproject -> shared version  -> shared version issues (excluding parent project issues)

Issue sorting code within a version+project scope:

      # Compare issues for rendering order 
      def gantt_issue_compare(x, y)
        if x.parent_id == y.parent_id
          # Same level in issue hierarchy
          basic_gantt_issue_compare(x, y)
        elsif x.root_id == y.root_id || x.root_id == y.id || y.root_id == x.id
          # Same issue hierarchy
          x.lft <=> y.lft
        else
          # Distinct hierarchies
          x.root_id <=> y.root_id
          # TODO : advanced sort between issues when ancestors have been filtered out by query
        end
      end

      def basic_gantt_issue_compare(x, y)
        if x.start_date == y.start_date
          x.id <=> y.id
        elsif x.start_date.nil?
          1 # null date appears at the end
        elsif y.start_date.nil?
          -1
        else
          x.start_date <=> y.start_date
        end
      end