Feature #8420
closed
Feature #9609: Upgrade to Rails 2.3.14
Consider removing #7013 workaround
0%
Description
As mentionned in config/environment.rb :
# TODO: Workaround for #7013 to be removed for 1.2.0 # Loads i18n 0.4.2 before Rails loads any more recent gem # 0.5.0 is not compatible with the old interpolation syntax # Plugins will have to migrate to the new syntax for 1.2.0 require 'rubygems' begin gem 'i18n', '0.4.2' rescue Gem::LoadError => load_error $stderr.puts %(Missing the i18n 0.4.2 gem. Please `gem install -v=0.4.2 i18n`) exit 1 end
Related issues
Updated by Jean-Philippe Lang over 13 years ago
I'm no longer sure that we should remove it.
If a new i18n release breaks the API again, Rails 2.3.11 will load it anyway.
Updated by Etienne Massip over 13 years ago
Isn't it the same kind of issue with Rails 2.3.11 not supporting RubyGems > 1.6 ?
What would you think of adding Bundler support (#5638) to add some dependencies check at startup such as rack, rubyGems, i18n, etc., maybe that would also prevent some support issues to be posted ?
Updated by Terence Mill over 13 years ago
Budnler support is adressed for next major, so can this get closed in favour for #5638 ?
Updated by Jean-Philippe Lang over 13 years ago
- Target version changed from 1.2.0 to Candidate for next major release
Etienne Massip wrote:
Isn't it the same kind of issue with Rails 2.3.11 not supporting RubyGems > 1.6 ?
No, rubygems is not a gem.
What would you think of adding Bundler support (#5638) to add some dependencies check at startup such as rack, rubyGems, i18n, etc., maybe that would also prevent some support issues to be posted ?
The only problem is i18n and the way the Rails dependency is done. In active_support/vendor.rb we have:
gem 'i18n', '>= 0.4.1'
which will load the more recent i18n version available. I think that the following would be safer:
gem 'i18n', '~> 0.4.1'
Updated by Etienne Massip about 13 years ago
- Status changed from New to Resolved
- Target version changed from Candidate for next major release to 1.3.0
- Resolution set to Fixed
Updated by Jean-Philippe Lang about 13 years ago
- Status changed from Resolved to Closed
As Rails 2.3.14 dependency is still '>= 0.4.1', I hope that i18n won't break the API in the future.