Project

General

Profile

Actions
Copy link

Feature #9720

closed

Add note number for single issue's PDF

Added by Akiko Takano almost 13 years ago. Updated almost 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toshi MARUYAMA
Category:
PDF export
Target version:
1.3.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

Please add note number for single issue not only for html but also PDF.

Files

Download all files
pdf.diff (1.13 KB) pdf.diff diff for changeset 6313:81b83bbb8e6d Akiko Takano, 2011-12-05 04:01
r8090.diff (692 Bytes) r8090.diff Toshi MARUYAMA, 2011-12-05 09:58
Actions
Copy link
 #1

Updated by Toshi MARUYAMA almost 13 years ago

  • Assignee set to Toshi MARUYAMA
  • Target version set to 1.3.0
Actions
Copy link
 #2

Updated by Toshi MARUYAMA almost 13 years ago

  • Target version deleted (1.3.0)
Actions
Copy link
 #3

Updated by Toshi MARUYAMA almost 13 years ago

  • Status changed from New to Closed
  • Target version set to 1.3.0
  • Resolution set to Fixed

Committed in trunk r8090 and 1.3-stable r8091, thanks.

Actions
Copy link
 #4

Updated by Etienne Massip almost 13 years ago

Having the note number right after the user name is not very readable, it feels like the note is referring to the user; what would you think of inserting it at the begin of the line or at least add a hyphen to separate username and note#?

It's fine in HTML since the note is at the end of the line.

Actions
Copy link
 #5

Updated by Toshi MARUYAMA almost 13 years ago

This is a patch to move note number at beginning line.
I remove "note", because there is no "note" translation.

Actions
Copy link
 #6

Updated by Etienne Massip almost 13 years ago

I tested 2 different versions of your patch:

  • #1 <date and time> - <username>
  • #1 - <date and time> - <username>

As a personal POV, I'd rather use the second one since, in the first one, the separation between note# last digit and date first digit is not obvious.

Actions
Copy link
 #7

Updated by Akiko Takano almost 13 years ago

MARUYAMA-san, Thanks for your work!

Actions
Copy link
 #8

Updated by Toshi MARUYAMA almost 13 years ago

I committed "#1 - <date and time> - <username>" in trunk r8099 and 1.3-stable r8100.

Actions
Copy link

Also available in: Atom PDF