From 501c9aed49de3dd246b24da476ebe2e30ded9362 Mon Sep 17 00:00:00 2001 From: Jan Schulz-Hofen Date: Mon, 2 Dec 2019 19:15:57 +0100 Subject: [PATCH 1/4] Use existing scopes instead of one-off AR condition --- app/models/issue_priority.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/issue_priority.rb b/app/models/issue_priority.rb index 106754293d..05be79dd1c 100644 --- a/app/models/issue_priority.rb +++ b/app/models/issue_priority.rb @@ -50,7 +50,7 @@ class IssuePriority < Enumeration # Updates position_name for active priorities # Called from migration 20121026003537_populate_enumerations_position_name def self.compute_position_names - priorities = where(:active => true).sort_by(&:position) + priorities = active if priorities.any? default = priorities.detect(&:is_default?) || priorities[(priorities.size - 1) / 2] priorities.each_with_index do |priority, index| -- 2.17.0