From 9308f0494b95dcbfa0810b65417ebfee09b0a59d Mon Sep 17 00:00:00 2001 From: Marius BALTEANU Date: Thu, 9 Jan 2020 10:33:55 +0200 Subject: [PATCH] Fix Internal Error when issue text custom field is shown in Spent time query results --- app/views/timelog/_list.html.erb | 5 +++-- test/functional/timelog_controller_test.rb | 15 +++++++++++++++ 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/app/views/timelog/_list.html.erb b/app/views/timelog/_list.html.erb index b3146c28b..582d1208c 100644 --- a/app/views/timelog/_list.html.erb +++ b/app/views/timelog/_list.html.erb @@ -50,11 +50,12 @@ <%= link_to_context_menu %> + <% @query.block_columns.each do |column| - if (text = column_content(column, issue)) && text.present? -%> + if (text = column_content(column, entry)) && text.present? -%> - <% if query.block_columns.count > 1 %> + <% if @query.block_columns.count > 1 %> <%= column.caption %> <% end %> <%= text %> diff --git a/test/functional/timelog_controller_test.rb b/test/functional/timelog_controller_test.rb index 6046b1cd1..6c69f6f9f 100644 --- a/test/functional/timelog_controller_test.rb +++ b/test/functional/timelog_controller_test.rb @@ -1430,4 +1430,19 @@ class TimelogControllerTest < Redmine::ControllerTest assert_select '+ span.count', :text => '2' end end + + def test_index_with_inline_issue_long_text_custom_field_column + field = IssueCustomField.create!(:name => 'Long text', :field_format => 'text', :full_width_layout => '1', + :tracker_ids => [1], :is_for_all => true) + issue = Issue.find(1) + issue.custom_field_values = {field.id => 'This is a long text'} + issue.save! + + get :index, :params => { + :set_filter => 1, + :c => ['subject', 'description', "issue.cf_#{field.id}"] + } + assert_response :success + assert_select "td.issue_cf_#{field.id}", :text => 'This is a long text' + end end -- 2.22.0