diff --git a/app/models/member_role.rb b/app/models/member_role.rb index 94c6615a28..a20531f94e 100644 --- a/app/models/member_role.rb +++ b/app/models/member_role.rb @@ -52,7 +52,7 @@ class MemberRole < ActiveRecord::Base private def remove_member_if_empty - if @member_removal != false && member.roles.empty? + if @member_removal != false && member.roles.reload.empty? member.destroy end end diff --git a/test/unit/member_test.rb b/test/unit/member_test.rb index fd54123cb7..139651f1b1 100644 --- a/test/unit/member_test.rb +++ b/test/unit/member_test.rb @@ -225,4 +225,14 @@ class MemberTest < ActiveSupport::TestCase ) end end + + def test_destroy_member_when_member_role_is_empty + member = Member.find(1) + + assert_difference 'Member.count', -1 do + member.role_ids = [] # Destroy roles associated with member + end + assert member.destroyed? + assert_raise(ActiveRecord::RecordNotFound) { Member.find(1) } + end end