From 27f7abcf9a60acae7554f958a93970f3e5f9c552 Mon Sep 17 00:00:00 2001
From: ishikawa999 <remember929@gmail.com>
Date: Fri, 20 Dec 2024 07:22:33 +0000
Subject: [PATCH] Replace legacy icons on search results pages with svg icons

---
 app/assets/images/icons.svg            | 16 ++++++++++++++++
 app/assets/stylesheets/application.css |  2 +-
 app/views/search/index.html.erb        |  3 ++-
 config/icon_source.yml                 |  4 ++++
 4 files changed, 23 insertions(+), 2 deletions(-)

diff --git a/app/assets/images/icons.svg b/app/assets/images/icons.svg
index 3bd8ae53b..87d0ee6e8 100644
--- a/app/assets/images/icons.svg
+++ b/app/assets/images/icons.svg
@@ -275,6 +275,11 @@
       <path d="M11 16a1 1 0 1 0 2 0a1 1 0 0 0 -2 0"/>
       <path d="M8 11v-4a4 4 0 1 1 8 0v4"/>
     </symbol>
+    <symbol viewBox="0 0 24 24" stroke-linecap="round" stroke-linejoin="round" id="icon--message">
+      <path d="M8 9h8"/>
+      <path d="M8 13h6"/>
+      <path d="M18 4a3 3 0 0 1 3 3v8a3 3 0 0 1 -3 3h-5l-5 3v-3h-2a3 3 0 0 1 -3 -3v-8a3 3 0 0 1 3 -3h12z"/>
+    </symbol>
     <symbol viewBox="0 0 24 24" stroke-linecap="round" stroke-linejoin="round" id="icon--move">
       <path d="M15 14l4 -4l-4 -4"/>
       <path d="M19 10h-11a4 4 0 1 0 0 8h1"/>
@@ -295,6 +300,17 @@
     <symbol viewBox="0 0 24 24" stroke-linecap="round" stroke-linejoin="round" id="icon--plugins">
       <path d="M4 7h3a1 1 0 0 0 1 -1v-1a2 2 0 0 1 4 0v1a1 1 0 0 0 1 1h3a1 1 0 0 1 1 1v3a1 1 0 0 0 1 1h1a2 2 0 0 1 0 4h-1a1 1 0 0 0 -1 1v3a1 1 0 0 1 -1 1h-3a1 1 0 0 1 -1 -1v-1a2 2 0 0 0 -4 0v1a1 1 0 0 1 -1 1h-3a1 1 0 0 1 -1 -1v-3a1 1 0 0 1 1 -1h1a2 2 0 0 0 0 -4h-1a1 1 0 0 1 -1 -1v-3a1 1 0 0 1 1 -1"/>
     </symbol>
+    <symbol viewBox="0 0 24 24" stroke-linecap="round" stroke-linejoin="round" id="icon--project">
+      <path d="M7 16.5l-5 -3l5 -3l5 3v5.5l-5 3z"/>
+      <path d="M2 13.5v5.5l5 3"/>
+      <path d="M7 16.545l5 -3.03"/>
+      <path d="M17 16.5l-5 -3l5 -3l5 3v5.5l-5 3z"/>
+      <path d="M12 19l5 3"/>
+      <path d="M17 16.5l5 -3"/>
+      <path d="M12 13.5v-5.5l-5 -3l5 -3l5 3v5.5"/>
+      <path d="M7 5.03v5.455"/>
+      <path d="M12 8l5 -3"/>
+    </symbol>
     <symbol viewBox="0 0 24 24" stroke-linecap="round" stroke-linejoin="round" id="icon--projects">
       <path d="M7 16.5l-5 -3l5 -3l5 3v5.5l-5 3z"/>
       <path d="M2 13.5v5.5l5 3"/>
diff --git a/app/assets/stylesheets/application.css b/app/assets/stylesheets/application.css
index 4e4b171fd..bdd571e8c 100644
--- a/app/assets/stylesheets/application.css
+++ b/app/assets/stylesheets/application.css
@@ -1847,7 +1847,7 @@ span.icon-label {
 .open .icon-folder:not(:has(svg)) { background-image: url(/folder_open.png); }
 .icon-package:not(:has(svg)) { background-image: url(/package.png); }
 .icon-user:not(:has(svg)) { background-image: url(/user.png); }
-.icon-project, .icon-projects:not(:has(svg)) { background-image: url(/projects.png); }
+.icon-project:not(:has(svg)), .icon-projects:not(:has(svg)) { background-image: url(/projects.png); }
 .icon-help:not(:has(svg)) { background-image: url(/help.png); }
 .icon-attachment:not(:has(svg)) { background-image: url(/attachment.png); }
 .icon-history:not(:has(svg)) { background-image: url(/history.png); }
diff --git a/app/views/search/index.html.erb b/app/views/search/index.html.erb
index ce7887a9d..7b5fc4f36 100644
--- a/app/views/search/index.html.erb
+++ b/app/views/search/index.html.erb
@@ -51,12 +51,13 @@
     <h3><%= l(:label_result_plural) %> (<%= @result_count %>)</h3>
     <% if @result_count_by_type['issues'].to_i > 0 && @search_attachments == '0' %>
       <p class="buttons">
-        <%= link_to l(:button_apply_issues_filter), issues_filter_path(@question, projects_scope: params[:scope], all_words: @all_words, titles_only: @titles_only, open_issues: @open_issues), :class => 'icon icon-list' %>
+        <%= link_to sprite_icon('list', l(:button_apply_issues_filter)), issues_filter_path(@question, projects_scope: params[:scope], all_words: @all_words, titles_only: @titles_only, open_issues: @open_issues), :class => 'icon icon-list' %>
       </p>
     <% end %>
     <dl id="search-results">
       <% @results.each do |e| %>
         <dt class="<%= e.event_type %> icon icon-<%= e.event_type %>">
+          <%= sprite_icon(e.event_type) %>
           <%= content_tag('span', e.project, :class => 'project') unless @project == e.project %>
           <%= link_to(highlight_tokens(e.event_title.truncate(255), @tokens), e.event_url) %>
         </dt>
diff --git a/config/icon_source.yml b/config/icon_source.yml
index 92ea716b1..bb61da387 100644
--- a/config/icon_source.yml
+++ b/config/icon_source.yml
@@ -115,6 +115,8 @@
   svg: refresh
 - name: projects
   svg: packages
+- name: project
+  svg: packages
 - name: package
   svg: package
 - name: custom-fields
@@ -131,6 +133,8 @@
   svg: message
 - name: comment
   svg: message
+- name: message
+  svg: message
 - name: arrow-right
   svg: arrow-big-right
 - name: wiki-page
-- 
2.47.1