Project

General

Profile

Forums » Development »

Too many revisions - the many single file commits

Added by Carsten Schurig over 13 years ago

Currently it's very difficult to follow the development of Redmine. The problem is, that there're so many commits for single files that would be better to be one or at least a few combined commits. E.g. all the late renaming as well as the "remove trailing white-spaces".

Is this a policy for redmine development to do single-file commits or why does this happen? Actually if I currently want to look at the recent changes, I've the feeling that the last 300 revisions (or even more) would have been about 10 "real" revisions at max. This way the SCM can hardly be used to track changes...


Replies (3)

RE: Too many revisions - the many single file commits - Added by James Bernard over 13 years ago

Toshi MARUYAMA wrote:

It is popular to separate revisions.
http://groups.google.com/group/thg-dev/msg/a02354b7800d6f87

They asked you to split your patch because they think there are several unrelated topics inside.

Combined change is very ugly.
https://www.chiliproject.org/projects/chiliproject/repository/revisions/07185fb169e7a532a038477a071cca5a50c67ca9

This commit deals with only one and very simple topic "Clean up trailing whitespace and tabs", it would not make sense to split it in 10,20,30 commits or one commit per file...

Carsten complained (and I agree with him) about dozens of revisions for a single topic so none of your two examples apply here.

RE: Too many revisions - the many single file commits - Added by Toshi MARUYAMA over 13 years ago

James Bernard wrote:

This commit deals with only one and very simple topic "Clean up trailing whitespace and tabs", it would not make sense to split it in 10,20,30 commits or one commit per file...

Carsten complained (and I agree with him) about dozens of revisions for a single topic so none of your two examples apply here.

Redmine repository is Subversion.
"svn merge" is equivalent with "git cherry-pick".
It is too hard to cherry-pick single revision such as https://www.chiliproject.org/projects/chiliproject/repository/revisions/07185fb169e7a532a038477a071cca5a50c67ca9 .

ChiliProject uses cherry-pick sometimes.
After this revision, ChiliProject developing pace is slow down.

    (1-3/3)