Project

General

Profile

Actions

Patch #10916

closed

Optimisation in issues relations display

Added by Jérôme BATAILLE almost 12 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

In the relations loop some variables are recalculated too many times


Files

Actions #1

Updated by Jean-Baptiste Barth almost 12 years ago

Setting.blah is already cached in an Setting's class variable. The other optimization might be relevant, it would save some == calls and conditions..

Actions #2

Updated by Jérôme BATAILLE over 11 years ago

Do you want us to bring a new patch taking in accound your remark ?

Actions #3

Updated by Jean-Philippe Lang about 11 years ago

  • Category set to Code cleanup/refactoring
  • Status changed from New to Closed
  • Target version set to 2.3.0

Variable named other_issue added to store relation.other_issue(@issue) as proposed in the patch, thanks.

Actions #4

Updated by Jérôme BATAILLE almost 7 years ago

Hi, you can indicate in the Resolution that's it's Fixed, if you have the time to, thanks a lot.

Actions #5

Updated by Toshi MARUYAMA almost 7 years ago

Jérôme BATAILLE wrote:

Hi, you can indicate in the Resolution that's it's Fixed, if you have the time to, thanks a lot.

"patch" tracker does not have "resolution" filed.

Actions

Also available in: Atom PDF