Project

General

Profile

Actions
Copy link

Patch #10916

closed

Optimisation in issues relations display

Added by Jérôme BATAILLE over 12 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Code cleanup/refactoring
Target version:
2.3.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

In the relations loop some variables are recalculated too many times

Files

app_views_issues_relations.rhtml_2012-05-14.diff (2.31 KB) app_views_issues_relations.rhtml_2012-05-14.diff Jérôme BATAILLE, 2012-05-14 18:23
Actions
Copy link
 #1

Updated by Jean-Baptiste Barth over 12 years ago

Setting.blah is already cached in an Setting's class variable. The other optimization might be relevant, it would save some == calls and conditions..

Actions
Copy link
 #2

Updated by Jérôme BATAILLE about 12 years ago

Do you want us to bring a new patch taking in accound your remark ?

Actions
Copy link
 #3

Updated by Jean-Philippe Lang almost 12 years ago

  • Category set to Code cleanup/refactoring
  • Status changed from New to Closed
  • Target version set to 2.3.0

Variable named other_issue added to store relation.other_issue(@issue) as proposed in the patch, thanks.

Actions
Copy link
 #4

Updated by Jérôme BATAILLE over 7 years ago

Hi, you can indicate in the Resolution that's it's Fixed, if you have the time to, thanks a lot.

Actions
Copy link
 #5

Updated by Toshi MARUYAMA over 7 years ago

Jérôme BATAILLE wrote:

Hi, you can indicate in the Resolution that's it's Fixed, if you have the time to, thanks a lot.

"patch" tracker does not have "resolution" filed.

Actions
Copy link

Also available in: Atom PDF