Actions
Defect #11209
closed
Wiki diff may generate broken HTML
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
If Wiki diff has a new line (not a changed line), diff page may generates broken HTML like:
<div class="text-diff"> h1. CookBook documentation <br /> Some updated [[documentation]] here... <span class="diff_in"> <br /> More contents...</span> </div>
Close </span> tag is escaped.
For example:
Before
h1. CookBook documentation Some updated [[documentation]] here...
After:
h1. CookBook documentation Some updated [[documentation]] here... More contents...
"More contents..." line is added. This case, diff page generates broken HTML.
Files
Related issues
Updated by Kouhei Sutou over 12 years ago
- File 0001-Fix-too-escaped-span-in-diff-page-for-Wiki-11209.patch 0001-Fix-too-escaped-span-in-diff-page-for-Wiki-11209.patch added
I attach a patch and test case for this issue.
It adds a new fixture data. So it may break other tests. I only tested this patch against test/functional/wiki_controller_test.rb. Sorry.
Updated by Jean-Philippe Lang over 12 years ago
- Status changed from New to Confirmed
Updated by Jean-Philippe Lang over 12 years ago
- Subject changed from diff page for Wiki may generate broken HTML to Wiki diff may generate broken HTML
- Status changed from Confirmed to Resolved
- Assignee set to Jean-Philippe Lang
- Target version set to 2.0.4
- Resolution set to Fixed
Fixed in r9895 with slight changes, thanks for digging into this.
Updated by Kouhei Sutou over 12 years ago
Thanks!
I've also found a similar problem in Wiki update notification mail. I'll submit a new ticket with test case later.
Actions