Defect #11209
Wiki diff may generate broken HTML
Status: | Closed | Start date: | ||
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | % Done: | 0% | ||
Category: | Wiki | |||
Target version: | 2.0.4 | |||
Resolution: | Fixed | Affected version: | 2.0.3 |
Description
If Wiki diff has a new line (not a changed line), diff page may generates broken HTML like:
<div class="text-diff"> h1. CookBook documentation <br /> Some updated [[documentation]] here... <span class="diff_in"> <br /> More contents...</span> </div>
Close </span>
tag is escaped.
For example:
Before
h1. CookBook documentation Some updated [[documentation]] here...
After:
h1. CookBook documentation Some updated [[documentation]] here... More contents...
"More contents..." line is added. This case, diff page generates broken HTML.
Related issues
Associated revisions
Fixed that wiki diff may produce html (#11209).
History
#1
Updated by Kouhei Sutou over 8 years ago
I attach a patch and test case for this issue.
It adds a new fixture data. So it may break other tests. I only tested this patch against test/functional/wiki_controller_test.rb. Sorry.
#2
Updated by Jean-Philippe Lang over 8 years ago
- Status changed from New to Confirmed
#3
Updated by Jean-Philippe Lang over 8 years ago
- Subject changed from diff page for Wiki may generate broken HTML to Wiki diff may generate broken HTML
- Status changed from Confirmed to Resolved
- Assignee set to Jean-Philippe Lang
- Target version set to 2.0.4
- Resolution set to Fixed
Fixed in r9895 with slight changes, thanks for digging into this.
#4
Updated by Kouhei Sutou over 8 years ago
Thanks!
I've also found a similar problem in Wiki update notification mail. I'll submit a new ticket with test case later.