https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292007-10-01T22:00:00ZRedmineRedmine - Defect #117: '\'(char code 0x5c) handling is improper in PDF outputhttps://www.redmine.org/issues/117?journal_id=3142007-10-01T22:00:00ZAruo Miura
<ul></ul><p>Hi.<br />I make patch for this problem.<br />This one can resolve 2 problems:<br />A:Iconv can't convert multi-byte string include '\'.<br />B:multi-byte character include 0x5c can't show in PDF.</p>
<p>I check only environments:<br />WindowsXP SP2/Japanese<br />ruby 1.8.6-p110<br />rails 1.2.3<br />redmine rev.781</p>
<pre><code class="diff syntaxhl"><span class="gh">Index: ifpdf_helper.rb
=================================================================
==
</span><span class="gd">--- ifpdf_helper.rb (Revision 781)
</span><span class="gi">+++ ifpdf_helper.rb (Working copy)
</span><span class="p">@@ -53,7 +53,13 @@</span>
def Cell(w,h=0,txt='',border=0,ln=0,align='',fill=0,link='')
@ic ||= Iconv.new(l(:general_pdf_encoding), 'UTF-8')
txt = begin
<span class="gd">- @ic.iconv(txt)
</span><span class="gi">+ txtar = txt.split('\\')
+ txtar << '' if txt[-1] == ?\\
+ txtar2 = []
+ txtar.each{|x|
+ txtar2 << @ic.iconv(x)
+ }
+ txtar2.join('\\').gsub(/\\/, "\\\\\\\\")
</span> rescue
txt
end
</code></pre> Redmine - Defect #117: '\'(char code 0x5c) handling is improper in PDF outputhttps://www.redmine.org/issues/117?journal_id=3132007-10-06T08:28:00ZJean-Philippe Langjp_lang@yahoo.fr
<ul></ul><p>Your fix (slightly edited) is committed in <a class="changeset" title="Fixed: improper 0x5c char handling in PDF output (Go Maeda)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/813">r813</a>.<br />Thanks for your help.</p> Redmine - Defect #117: '\'(char code 0x5c) handling is improper in PDF outputhttps://www.redmine.org/issues/117?journal_id=3122007-10-06T18:04:00ZGo MAEDA
<ul></ul><p>Thanks for your work. The fix is of great benefit to MBCS users.</p>
<p>Although the patch's author is Aruo Miura, my name is<br />written in svn commit log instead of Miura.</p> Redmine - Defect #117: '\'(char code 0x5c) handling is improper in PDF outputhttps://www.redmine.org/issues/117?journal_id=3112007-10-07T08:06:00ZJean-Philippe Langjp_lang@yahoo.fr
<ul></ul><p>Oh, I'm sorry. I didn't notice that the patch was from someone<br />else.</p>
<p>Big thanks to Aruo Miura :-)</p> Redmine - Defect #117: '\'(char code 0x5c) handling is improper in PDF outputhttps://www.redmine.org/issues/117?journal_id=3102007-10-07T15:35:00ZAruo Miura
<ul></ul><p>No problem.<br />Thanks for your work.</p>