Project

General

Profile

Actions
Copy link

Patch #12911

closed

Fix 500 error for requests to the settings path for non-configurable plugins

Added by Harry Garrood over 12 years ago. Updated over 12 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Code cleanup/refactoring
Target version:
2.3.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

When a non-configurable plugin is specified in a GET or POST to /settings/plugin/:id, a NoMethodError will be raised, and Redmine will respond with status 500.

The attached patch fixes this by rendering a 404 for both GETs and POSTs unless the plugin is configurable. It's based on trunk r11204.

I've also updated and added tests.

Files

make_plugin_settings_path_404_for_non_configurable_plugins.patch (1.63 KB) make_plugin_settings_path_404_for_non_configurable_plugins.patch Harry Garrood, 2013-01-20 03:46
Actions
Copy link
 #1

Updated by Jean-Philippe Lang over 12 years ago

  • Category set to Code cleanup/refactoring
  • Status changed from New to Closed
  • Target version set to 2.3.0

Patch committed in r11216, thanks!

Actions
Copy link

Also available in: Atom PDF