Patch #12911
Fix 500 error for requests to the settings path for non-configurable plugins
Status: | Closed | Start date: | ||
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | - | % Done: | 0% | |
Category: | Code cleanup/refactoring | |||
Target version: | 2.3.0 |
Description
When a non-configurable plugin is specified in a GET or POST to /settings/plugin/:id, a NoMethodError will be raised, and Redmine will respond with status 500.
The attached patch fixes this by rendering a 404 for both GETs and POSTs unless the plugin is configurable. It's based on trunk r11204.
I've also updated and added tests.
Associated revisions
Fix 500 error for requests to the settings path for non-configurable plugins (#12911).
Path by Harry Garrood.
History
#1
Updated by Jean-Philippe Lang almost 8 years ago
- Category set to Code cleanup/refactoring
- Status changed from New to Closed
- Target version set to 2.3.0
Patch committed in r11216, thanks!