Project

General

Profile

Actions

Defect #13630

closed

PDF export generates the issue id twice

Added by F Schroedter over 11 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
PDF export
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

The pdf export generates the issue id twice:

PDF screenshot

I added a patch that fixes this bug.


Files

double_issueID.png (10.7 KB) double_issueID.png PDF screenshot F Schroedter, 2013-03-28 19:26
pdf.rb.patch (2.09 KB) pdf.rb.patch F Schroedter, 2013-03-28 19:27
pdf.rb.2.patch (6.04 KB) pdf.rb.2.patch F Schroedter, 2013-03-29 12:38
pdf.rb.3.patch (6.05 KB) pdf.rb.3.patch .inject(0, :+) F Schroedter, 2013-03-29 15:06

Related issues

Related to Redmine - Defect #13689: Duplicate column Id em IssuesClosed

Actions
Precedes Redmine - Defect #14178: PDF API broken in version 2.3.1Closed

Actions
Actions #1

Updated by Etienne Massip over 11 years ago

  • Status changed from New to Confirmed
  • Target version set to 2.3.1

Regression.

Not sure the patch is complete?

Actions #2

Updated by F Schroedter over 11 years ago

This patch should be complete now. It also includes some code improvements: .inject(0) {|s,v| s += v} is replaced by .inject(:+)

Actions #3

Updated by Etienne Massip over 11 years ago

F Schroedter wrote:

This patch should be complete now. It also includes some code improvements: .inject(0) {|s,v| s += v} is replaced by .inject(:+)

Looks fine. What Ruby version did you test it with, please?

Actions #4

Updated by F Schroedter over 11 years ago

Tested on ruby 1.9.2 and 1.9.3. The code improvement should also work on 1.8.7: http://stackoverflow.com/questions/1538789/how-to-sum-array-members-in-ruby

Actions #5

Updated by Etienne Massip over 11 years ago

Looks like .inject(0) {|s,w| s += w} should be replaced by .inject(0, :+) rather than .inject(:+)?

Actions #6

Updated by F Schroedter over 11 years ago

You are right.

Actions #7

Updated by Etienne Massip over 11 years ago

  • Status changed from Confirmed to Resolved
  • Resolution set to Fixed

Fixed with r11693.

Actions #8

Updated by Etienne Massip over 11 years ago

  • Status changed from Resolved to Closed

Merged from trunk.

Actions

Also available in: Atom PDF