Feature #14030
closedAllow plugins to put gems inside PluginGemfile
0%
Description
Having plugins put their gem requirements in Gemfile means that doing anything which involves Bundler inside the plugin directory (eg rake redmine:plugins:test
) breaks.
Could Redmine's own Gemfile be changed so that it looks for files names, say, PluginGemfile
as well?
Updated by Harry Garrood over 11 years ago
To clarify -- Bundler sees a Gemfile in the current directory (/path/to/redmine/plugins/redmine_foo), and assumes that it is the root of the project, which is not the case.
Updated by Jean-Baptiste Barth over 11 years ago
- Assignee set to Jean-Baptiste Barth
Obviously you shouldn't run redmine rake tasks directly inside plugins. Bundler is not broken inside plugins per se. As plugins cannot run without redmine core, commands should be run from redmine core and optionnally limit effects to a specific plugin (with NAME=redmine_foo for instance
).
Renaming things in a non-standard fashion would break plugins possible integration as rubygems which is not better I think.
Updated by Harry Garrood over 11 years ago
At the moment you shouldn't, but it would certainly be nice (and be less confusing for plugin authors) to be able to.
I don't see how it would break possible integration with rubygems -- it certainly wouldn't be the first gemfile to not be called Gemfile:
bundle install
has a--gemfile=FILE
switch to allow you to use files with different names.- Here: https://github.com/grosser/fast_gettext/tree/master/gemfiles is an example of a repository which contains multiple Gemfiles so that CI tests can be run against each set of gems.
Updated by Jean-Baptiste Barth over 11 years ago
Yes, you're right, I spoke too soon. Only gemspec is required for rubygems integration, some gems don't even have a Gemfile and it works well.
I'd love to hear Jean-Philippe thoughts on this point.
Updated by Jean-Philippe Lang over 11 years ago
OK for loading PluginGemfile
. Gemfile
should still be loaded if it exists for compatibility.
Updated by Robin Böning about 11 years ago
I think this Issue can be closed, since the Gemfile also loads Gemfiles of plugins, right?
Updated by Jean-Baptiste Barth over 10 years ago
- Status changed from New to Closed
- Target version set to 2.6.0
- Resolution set to Fixed
Updated by Jigar Mehta almost 4 years ago
I am currently facing a similar problem.
- I'm working on a Redmine plugin, mainly adding tests.
- Plugin location: plugins/toggl2redmine - it's detected correctly.
- I wish to use Pry for debugging while I write my tests.
- Here's what I've tried:
- Created a Gemfile in the root of my plugin and ran `bundle install` in Redmine root.
- Created a PluginGemfile in the root of my plugin and ran `bundle install` in Redmine root.
- Installed "pry" globally with "gem install pry"
None of the above seem to make "pry" available in my test. Nothing works, except when I add "pry" directly into "REDMINE/Gemfile".
I add some "puts" in that Gemfile and found that the `Dir.glob` block that tries to load the plugin gemfiles is actually detecting my plugin's Gemfile or PluginGemfile correctly, but just that pry is not installed even after "eval_gemfile". Am I missing something? Here's how my Gemfile looks:
# frozen_string_literal: true source 'https://rubygems.org' # I've also tried specifying a version, but the results are the same. gem 'pry', group: [:development, :test]
I've also tried doing a `Bundler.require(*Rails.groups)` in my `test_helper.rb`. Nothing works :(
Update: It works!¶
Finally, I think I figured it out. Since the plugin Gemfile is included from within a main Gemfile, it does not need a "source". So, removing the "source" line fixes the problem.