Allow plugins to put gems inside PluginGemfile
|Assignee:||Jean-Baptiste Barth||% Done:|
Having plugins put their gem requirements in Gemfile means that doing anything which involves Bundler inside the plugin directory (eg
rake redmine:plugins:test) breaks.
Could Redmine's own Gemfile be changed so that it looks for files names, say,
PluginGemfile as well?
#2 Updated by Jean-Baptiste Barth over 8 years ago
- Assignee set to Jean-Baptiste Barth
Obviously you shouldn't run redmine rake tasks directly inside plugins. Bundler is not broken inside plugins per se. As plugins cannot run without redmine core, commands should be run from redmine core and optionnally limit effects to a specific plugin (with
NAME=redmine_foo for instance).
Renaming things in a non-standard fashion would break plugins possible integration as rubygems which is not better I think.
#3 Updated by Harry Garrood over 8 years ago
At the moment you shouldn't, but it would certainly be nice (and be less confusing for plugin authors) to be able to.
I don't see how it would break possible integration with rubygems -- it certainly wouldn't be the first gemfile to not be called Gemfile:
bundle installhas a
--gemfile=FILEswitch to allow you to use files with different names.
- Here: https://github.com/grosser/fast_gettext/tree/master/gemfiles is an example of a repository which contains multiple Gemfiles so that CI tests can be run against each set of gems.
#7 Updated by Jean-Baptiste Barth about 7 years ago
- Status changed from New to Closed
- Target version set to 2.6.0
- Resolution set to Fixed
@Robin: not really, the requested feature is actually to be able to avoid the "Gemfile" file which has a specific meaning for bundler, so you could run bundler commands inside plugins without having bundler cry.
The feature was added in r13337.
#8 Updated by Jigar Mehta 8 months ago
I am currently facing a similar problem.
- I'm working on a Redmine plugin, mainly adding tests.
- Plugin location: plugins/toggl2redmine - it's detected correctly.
- I wish to use Pry for debugging while I write my tests.
- Here's what I've tried:
- Created a Gemfile in the root of my plugin and ran `bundle install` in Redmine root.
- Created a PluginGemfile in the root of my plugin and ran `bundle install` in Redmine root.
- Installed "pry" globally with "gem install pry"
None of the above seem to make "pry" available in my test. Nothing works, except when I add "pry" directly into "REDMINE/Gemfile".
I add some "puts" in that Gemfile and found that the `Dir.glob` block that tries to load the plugin gemfiles is actually detecting my plugin's Gemfile or PluginGemfile correctly, but just that pry is not installed even after "eval_gemfile". Am I missing something? Here's how my Gemfile looks:
# frozen_string_literal: true source 'https://rubygems.org' # I've also tried specifying a version, but the results are the same. gem 'pry', group: [:development, :test]
I've also tried doing a `Bundler.require(*Rails.groups)` in my `test_helper.rb`. Nothing works :(
Update: It works!¶
Finally, I think I figured it out. Since the plugin Gemfile is included from within a main Gemfile, it does not need a "source". So, removing the "source" line fixes the problem.