https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292013-07-08T08:22:55ZRedmineRedmine - Defect #14405: Alternate repo commit: link wrong when automatically added from a commit messagehttps://www.redmine.org/issues/14405?journal_id=503932013-07-08T08:22:55ZOlivier Mehani
<ul></ul><p>We also have a ticket of our own to track this issue [0].</p>
<p>[0] <a class="external" href="http://oml.mytestbed.net/issues/1352">http://oml.mytestbed.net/issues/1352</a></p> Redmine - Defect #14405: Alternate repo commit: link wrong when automatically added from a commit messagehttps://www.redmine.org/issues/14405?journal_id=513382013-08-22T08:11:52ZChristoph Dwertmann
<ul></ul><p>Patch: see below</p> Redmine - Defect #14405: Alternate repo commit: link wrong when automatically added from a commit messagehttps://www.redmine.org/issues/14405?journal_id=513392013-08-22T08:12:52ZOlivier Mehani
<ul></ul><p>Looking at how Redmine formats svn links (<code>PROJECT:REPONAME|rREV</code>), I am starting to think that the commit link-generation is good, but the parsing is not.</p>
<p>The link generation creates something of the forrm <code>PROJECT:REPONAME|commit:SHA</code>, while the parsing expects <code>PROJECT:commit:REPONAME|SHA</code>. Trying to map SVN URLs to Git urls, <code>commit:</code> as the equivalent of <code>r</code>, which I call <code>MARKER_</code>, and <code>ID</code> as an SCM-independent commit ID, this gives the following:</p>
<ul>
<li>SVN: <code>PROJECT:REPONAME|MARKER_ID</code></li>
<li>Git (generated): <code>PROJECT:REPONAME|MARKER_ID</code></li>
<li>Git (parsing): <code>PROJECT:MARKER_REPONAME|ID</code></li>
</ul>
<p>The SVN and Git (generated) schemas perfectly match, but are at odds with Git (parsing).</p>
<p>I'd say the problem is therefore in the parsing code, rather than the code generator.</p> Redmine - Defect #14405: Alternate repo commit: link wrong when automatically added from a commit messagehttps://www.redmine.org/issues/14405?journal_id=513422013-08-22T09:06:51ZChristoph Dwertmann
<ul><li><strong>File</strong> <a href="/attachments/10311">14405.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/10311/14405.patch">14405.patch</a> added</li></ul> Redmine - Defect #14405: Alternate repo commit: link wrong when automatically added from a commit messagehttps://www.redmine.org/issues/14405?journal_id=513462013-08-22T11:30:22ZToshi MARUYAMA
<ul><li><strong>Category</strong> set to <i>SCM</i></li></ul> Redmine - Defect #14405: Alternate repo commit: link wrong when automatically added from a commit messagehttps://www.redmine.org/issues/14405?journal_id=513762013-08-23T14:16:28ZMarkus Andree
<ul></ul><p>I can confirm this bug. I have the same problem with git.<br />Working links are as expected:</p>
<ul>
<li><code>PROJECT:commit:REPONAME|COMMITID</code></li>
<li><code>commit:REPONAME|COMMITID</code></li>
<li><code>commit:COMMITID - for default repo</code></li>
</ul>
<p>But automatic generated links for non default repo is:</p>
<p><code>REPONAME|commit:COMMITID</code></p>
<p>The patch looks good for me, I'll test that</p> Redmine - Defect #14405: Alternate repo commit: link wrong when automatically added from a commit messagehttps://www.redmine.org/issues/14405?journal_id=550672014-02-27T00:12:55ZPetr Bela
<ul></ul><p>Same problem, the patch seems to work fine.</p> Redmine - Defect #14405: Alternate repo commit: link wrong when automatically added from a commit messagehttps://www.redmine.org/issues/14405?journal_id=553722014-03-17T05:28:31ZToshi MARUYAMA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Resolution</strong> set to <i>Duplicate</i></li></ul><p>Duplicate with <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Commit reference: autogenerated issue note has wrong commit link syntax in multi-repo or cross-pr... (Closed)" href="https://www.redmine.org/issues/13544">#13544</a>.</p> Redmine - Defect #14405: Alternate repo commit: link wrong when automatically added from a commit messagehttps://www.redmine.org/issues/14405?journal_id=553732014-03-17T05:28:43ZToshi MARUYAMA
<ul><li><strong>Is duplicate of</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/13544">Defect #13544</a>: Commit reference: autogenerated issue note has wrong commit link syntax in multi-repo or cross-project context</i> added</li></ul>