https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292013-07-10T09:07:51ZRedmineRedmine - Defect #14422: CVS root_url not recognized when connection string does not include porthttps://www.redmine.org/issues/14422?journal_id=504362013-07-10T09:07:51ZToshi MARUYAMA
<ul><li><strong>Target version</strong> set to <i>2.3.2</i></li></ul> Redmine - Defect #14422: CVS root_url not recognized when connection string does not include porthttps://www.redmine.org/issues/14422?journal_id=504382013-07-10T11:42:15ZToshi MARUYAMA
<ul><li><strong>Target version</strong> changed from <i>2.3.2</i> to <i>2.4.0</i></li></ul> Redmine - Defect #14422: CVS root_url not recognized when connection string does not include porthttps://www.redmine.org/issues/14422?journal_id=505292013-07-13T11:04:16ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Needs feedback</i></li></ul><p>Test added in <a class="changeset" title="Adds a test for CvsAdapter#root_url_path (#14422)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/12017">r12017</a>, it passes without your proposed fix. Would you have a failing test?</p> Redmine - Defect #14422: CVS root_url not recognized when connection string does not include porthttps://www.redmine.org/issues/14422?journal_id=505442013-07-15T06:03:46ZDominik Follmann
<ul></ul><p>Good morning.<br />Sorry, I was wrong in my description and copy-pasted the wrong CVSROOT. This happened, because I already put wrong comments to my source code when I implemented the patch some weeks ago ;-)<br />What I meant was:<br /><pre>:pserver:cvs_user:cvs_password@123.456.789.123/repo</pre><br />So without the explicit port after the IP-Address.<br />So the correct test would be:<br /><pre>
def test_root_url_path
adapter = Redmine::Scm::Adapters::CvsAdapter.new('foo', ':pserver:cvs_user:cvs_password@123.456.789.123/repo')
assert_equal '/repo', adapter.send(:root_url_path)
end
</pre><br />Regards</p> Redmine - Defect #14422: CVS root_url not recognized when connection string does not include porthttps://www.redmine.org/issues/14422?journal_id=505712013-07-15T21:08:11ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Tracker</strong> changed from <i>Patch</i> to <i>Defect</i></li><li><strong>Subject</strong> changed from <i>Improvement for CVS-Adapter to handle CVSROOT correct</i> to <i>CVS root_url not recognized when connection string does not include port</i></li><li><strong>Status</strong> changed from <i>Needs feedback</i> to <i>Resolved</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li><li><strong>Target version</strong> changed from <i>2.4.0</i> to <i>2.3.3</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>The proposed patch matches an IP adress only. It won't work if a host name is used.<br />A different fix is committed in <a class="changeset" title="CVS root_url not recognized when connection string does not include port (#14422)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/12027">r12027</a>, thanks for pointing this out.</p> Redmine - Defect #14422: CVS root_url not recognized when connection string does not include porthttps://www.redmine.org/issues/14422?journal_id=505792013-07-16T05:55:52ZDominik Follmann
<ul></ul><p>Hey, you're right, I forgot the hostname possibility.Thank you for the improvement!</p> Redmine - Defect #14422: CVS root_url not recognized when connection string does not include porthttps://www.redmine.org/issues/14422?journal_id=507832013-07-26T03:02:06Ztyrel cropper
<ul><li><strong>File</strong> <a href="/attachments/10122">cvs_adapter.rb (1).patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/10122/cvs_adapter.rb%20(1).patch">cvs_adapter.rb (1).patch</a> added</li></ul> Redmine - Defect #14422: CVS root_url not recognized when connection string does not include porthttps://www.redmine.org/issues/14422?journal_id=508462013-07-28T20:49:04ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul><p>Merged.</p>