Project

General

Profile

Actions

Defect #1612

closed

redmine links of type class:id do not like to be before a period.

Added by Paul Rivier almost 16 years ago. Updated almost 16 years ago.

Status:
Closed
Priority:
Normal
Category:
Wiki
Target version:
-
Start date:
2008-07-09
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Exemple : please have a look in source:trunk.
while "source:trunk" would work, "source:trunk." wont.

It is quiet common to put a link at the end of the sentence, therefore I think the regexp should exclude this dot when followed by a blanck or an end of line.

What do others think ?


Files

repo_links.patch (2.05 KB) repo_links.patch patch against current stable 0.7.3 Paul Rivier, 2008-07-10 15:16
repo_link.patch (2.05 KB) repo_link.patch patch against current trunk r1648 Paul Rivier, 2008-07-10 15:16
Actions #1

Updated by Jean-Philippe Lang almost 16 years ago

I agree. Do you have a patch ?

Actions #2

Updated by Paul Rivier almost 16 years ago

Here we go.
It turns path matching to non greedy variant, so the stop condition will work. The stop condition has been slightly changed as well. There are 2 or 3 test cases included also.

Actions #3

Updated by Jean-Philippe Lang almost 16 years ago

  • Status changed from New to Closed
  • Resolution set to Fixed

Fix committed in r1650 with a few additional tests (source file name containing a period).

Actions

Also available in: Atom PDF