https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292014-03-05T19:27:50ZRedmineRedmine - Patch #16240: Private notes should be marked more clearlyhttps://www.redmine.org/issues/16240?journal_id=551952014-03-05T19:27:50ZJan from Planio www.plan.io
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/55195/diff?detail_id=40780">diff</a>)</li></ul> Redmine - Patch #16240: Private notes should be marked more clearlyhttps://www.redmine.org/issues/16240?journal_id=569602014-06-22T14:31:35ZToshi MARUYAMA
<ul><li><strong>Target version</strong> changed from <i>Candidate for next minor release</i> to <i>2.6.0</i></li></ul> Redmine - Patch #16240: Private notes should be marked more clearlyhttps://www.redmine.org/issues/16240?journal_id=584422014-09-06T02:34:00ZJean-Baptiste Barth
<ul><li><strong>Assignee</strong> set to <i>Jean-Baptiste Barth</i></li></ul><p>I like the idea, and I'm afraid nobody else is looking at this for now.</p>
<p>That's the major point that keeps me with my absurd "redmine_comments" plugin on my redmine instances. I took the approach even further with a completely different style for private notes (= internal comments for staff in my case ; but there may be other use cases?). I guess it's too opinionated but let me know what you think: <a class="external" href="https://github.com/jbbarth/redmine_comments#screenshot">https://github.com/jbbarth/redmine_comments#screenshot</a></p>
<p>In any case I think the actual integration has to be improved, so I take the issue. Depending on your feedback I'll commit your change as is, it looks good to me.</p> Redmine - Patch #16240: Private notes should be marked more clearlyhttps://www.redmine.org/issues/16240?journal_id=584862014-09-08T10:33:04ZJan from Planio www.plan.io
<ul></ul><blockquote>
<p>I took the approach even further with a completely different style for private notes (= internal comments for staff in my case ; but there may be other use cases?). I guess it's too opinionated but let me know what you think: <a class="external" href="https://github.com/jbbarth/redmine_comments#screenshot">https://github.com/jbbarth/redmine_comments#screenshot</a></p>
</blockquote>
<p>I didn't try the plugin, just had a look at the screenshot. As you might have noticed in my previous comments, I am a big fan of consistency, especially when it comes to UI concepts. Therefore, I wanted to add the red <span style="background-color:red;color:white;"> PRIVATE </span> label: because it is used on private issues also and will be recognized by users easily (as opposed to the vertical red line by itself; I think it can easily be overlooked; or people could notice it but would not know what it means).</p>
<p>Your screenshot in itself looks consistent to me and I like it. However, I am not sure how it relates to the Redmine core themes? The regular journal has a yellow background and a 1px silver border. That's not the default Redmine theme, is it? Do you have a demo Redmine where one can try out the plugin?</p> Redmine - Patch #16240: Private notes should be marked more clearlyhttps://www.redmine.org/issues/16240?journal_id=585082014-09-09T03:54:49ZJean-Baptiste Barth
<ul><li><strong>Status</strong> changed from <i>Needs feedback</i> to <i>Closed</i></li></ul><p>Actually I don't suggest we switch to "my" design directly, I was just wondering if we should push the design change further. Anyway you're right I'm already on a theme slightly different from the default ones.</p>
<p>The first step you propose is already nice. I committed it in <a class="changeset" title="Mark private notes more clearly (#16240). Contributed by Jan Schulz-Hofen." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13367">r13367</a>.</p>
<p>One note about this: the locale key is the one used for private <em>issues</em>, while private notes are marked with <code>l(:field_private_notes)</code>, but the key is pluralized, so it was a bit weird to have a pluralized expression beside each individual note. Hence I left your patch exactly as is...</p>
<p>Thanks!</p> Redmine - Patch #16240: Private notes should be marked more clearlyhttps://www.redmine.org/issues/16240?journal_id=585752014-09-11T15:52:58ZJan from Planio www.plan.io
<ul></ul><p>Thank you !</p>