https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292014-03-15T10:44:39ZRedmineRedmine - Patch #16314: Redirect back is overheatedhttps://www.redmine.org/issues/16314?journal_id=553442014-03-15T10:44:39ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Tracker</strong> changed from <i>Defect</i> to <i>Patch</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li></ul><p>Anton Orel wrote:</p>
<blockquote>
<p>Take a look at these code lines:</p>
<p><a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/app/controllers/application_controller.rb#L368">source:app/controllers/application_controller.rb#L368</a><br />It is not used at all.</p>
</blockquote>
<p>It's used at least in <code>ContextMenusController</code>.</p>
<blockquote>
<p><a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/app/controllers/application_controller.rb#L399">source:app/controllers/application_controller.rb#L399</a><br />It uses same functionality that method above (relies on HTTP_REFERER).</p>
</blockquote>
<p>Not the same functionnality, one relies on the :back_url param, the other one on HTTP_REFERER. But please provide a patch if you think they can be merged in a single one.</p>
<blockquote>
<p><a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/app/helpers/application_helper.rb#L1100">source:app/helpers/application_helper.rb#L1100</a><br />It could be replaced with `helper_method :back_url`.</p>
</blockquote>
<p>Please provide a patch.</p>
<blockquote>
<p><a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/app/controllers/application_controller.rb#L390">source:app/controllers/application_controller.rb#L390</a><br />This condition is never satisfied. I did not find an usage.</p>
</blockquote>
<p>Used at least in AccountController.</p> Redmine - Patch #16314: Redirect back is overheatedhttps://www.redmine.org/issues/16314?journal_id=557132014-04-04T08:05:07ZToshi MARUYAMA
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/55713/diff?detail_id=41670">diff</a>)</li></ul>