Project

General

Profile

Actions

Defect #16321

closed

Custom Fields with "Link values to URL" set are displayed as escaped html in email

Added by Todd Hambley almost 11 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Normal
Category:
Email notifications
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

It looks like the function formatted_value in source:/trunk/lib/redmine/field_format.rb accepts a parameter html, but never uses it. Custom fields with a url pattern present are always returned as links.

Example Custom Field "External Link":

Format: Integer
Name: External Link
Link values to URL: https://support.example.com/tasks/%value%

Display in notification email:

External Link: <a href="https://support.example.com/tasks/26215">26215</a>

Environment:

  Redmine version                2.5.0.stable.12954
  Ruby version                   1.9.3-p448 (2013-06-27) [i686-linux]
  Rails version                  3.2.17
  Environment                    production
  Database adapter               Mysql2


Files

field_format.rb.patch (644 Bytes) field_format.rb.patch uses parameter named html Todd Hambley, 2014-03-14 02:53
Actions #1

Updated by Todd Hambley almost 11 years ago

Attached patch uses html parameter to produce expected output.

field_format.rb (revision 12954)

Actions #2

Updated by Jean-Philippe Lang almost 11 years ago

  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Target version set to 2.5.1
  • Resolution set to Fixed

Fixed in r12967, thanks for pointing this out.

Actions #3

Updated by Jean-Philippe Lang almost 11 years ago

  • Status changed from Resolved to Closed

Merged.

Actions

Also available in: Atom PDF