https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292010-07-07T11:30:08ZRedmineRedmine - Feature #1725: Delete button on commentshttps://www.redmine.org/issues/1725?journal_id=180232010-07-07T11:30:08ZFelix Schäfer
<ul><li><strong>Assignee</strong> set to <i>Felix Schäfer</i></li></ul><p>I've been wondering about this too, will have a look at it and see how quickly feasible it is.</p> Redmine - Feature #1725: Delete button on commentshttps://www.redmine.org/issues/1725?journal_id=180342010-07-07T18:00:47ZFelix Schäfer
<ul><li><strong>File</strong> <a href="/attachments/4093">add_a_delete_link_to_journal_entries.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/4093/add_a_delete_link_to_journal_entries.patch">add_a_delete_link_to_journal_entries.patch</a> added</li><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>Target version</strong> set to <i>1.0.1</i></li></ul><p>The supplied patch adds a delete button to an issue's journal entries, only for users with the right to edit the journal entry.</p> Redmine - Feature #1725: Delete button on commentshttps://www.redmine.org/issues/1725?journal_id=189462010-08-04T01:01:24ZEric Davis
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>7</i></li></ul> Redmine - Feature #1725: Delete button on commentshttps://www.redmine.org/issues/1725?journal_id=195032010-08-19T01:20:30ZEric Davis
<ul><li><strong>Assignee</strong> changed from <i>Felix Schäfer</i> to <i>Eric Davis</i></li><li><strong>Target version</strong> deleted (<del><i>1.0.1</i></del>)</li></ul><p>There is a problem with this patch. Journals are only deleted if:</p>
<ol>
<li>The notes are empty and</li>
<li>The details are empty</li>
</ol>
<p>All this patch does is to clear the notes. If a Journal had details, it wouldn't be deleted. There are two options we can do here:</p>
<ol>
<li>Add a new action to really delete a Journal and provide a link to it, or</li>
<li>Change this icon so it's clear that it only clears the note.</li>
</ol>
<p>I've added Holger to this issue, I know he has an opinion about deleting things like Journals and I would like to hear what he thinks.</p> Redmine - Feature #1725: Delete button on commentshttps://www.redmine.org/issues/1725?journal_id=197022010-08-25T13:03:01ZFelix Schäfer
<ul></ul><p>The scope of the patch wasn't to delete journals but the notes attached to it, which is currently possible to if you edit the notes to an empty string. The current functions quote and edit only work on the notes too, so I don't think that would be that misleading.</p> Redmine - Feature #1725: Delete button on commentshttps://www.redmine.org/issues/1725?journal_id=198792010-09-01T00:01:13ZEric Davis
<ul></ul><p>Maybe the title attribute should say "Delete notes" then. What do you think?</p> Redmine - Feature #1725: Delete button on commentshttps://www.redmine.org/issues/1725?journal_id=198832010-09-01T07:24:44ZFelix Schäfer
<ul><li><strong>Assignee</strong> changed from <i>Eric Davis</i> to <i>Felix Schäfer</i></li></ul><p>Can do that, I'll change the other titles (edit and quote) too to reflect that if it's ok with you?</p> Redmine - Feature #1725: Delete button on commentshttps://www.redmine.org/issues/1725?journal_id=203352010-09-15T21:32:56ZFelix Schäfer
<ul><li><strong>Assignee</strong> changed from <i>Felix Schäfer</i> to <i>Eric Davis</i></li></ul><p>Eric, I slightly reworked the patch to have the title say "Delete notes", the confirmation pop-up now also states that the changes to the issue will not be reverted if the journal details are not empty.</p>
<p>See <a class="external" href="http://github.com/thegcat/redmine/commit/5be3c6e9b405bf03ad69226e8235e3d6618adbf5">http://github.com/thegcat/redmine/commit/5be3c6e9b405bf03ad69226e8235e3d6618adbf5</a> for the change.</p> Redmine - Feature #1725: Delete button on commentshttps://www.redmine.org/issues/1725?journal_id=217262010-10-25T14:59:36ZEric Davis
<ul><li><strong>Assignee</strong> deleted (<del><i>Eric Davis</i></del>)</li></ul> Redmine - Feature #1725: Delete button on commentshttps://www.redmine.org/issues/1725?journal_id=251192011-02-11T19:45:40ZBrian Lindahl
<ul></ul><p>created a related patch for rolling back journal entries <a class="issue tracker-3 status-1 priority-4 priority-default" title="Patch: Patch providing issue journal rollback (New)" href="https://www.redmine.org/issues/7610">#7610</a></p>
<p>This rolls back the changes made to the issue as well as removing the journal entry. Note that this capability is only enabled for the last journal entry (for obvious reasons).</p> Redmine - Feature #1725: Delete button on commentshttps://www.redmine.org/issues/1725?journal_id=394232012-07-02T17:03:25Zrm user
<ul></ul><p>another 4 years issue.. :(</p> Redmine - Feature #1725: Delete button on commentshttps://www.redmine.org/issues/1725?journal_id=442262013-01-13T20:04:15ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>7</i> to <i>New</i></li></ul><p>Assigned issue with no assignee back to New status.</p> Redmine - Feature #1725: Delete button on commentshttps://www.redmine.org/issues/1725?journal_id=554952014-03-21T10:52:43ZLuis Serrano Aranda
<ul></ul><p>+1</p> Redmine - Feature #1725: Delete button on commentshttps://www.redmine.org/issues/1725?journal_id=555562014-03-28T06:54:48ZTerry Cullen
<ul></ul><p>+1</p> Redmine - Feature #1725: Delete button on commentshttps://www.redmine.org/issues/1725?journal_id=555582014-03-28T09:34:15Zrm user
<ul></ul><p>what's up with this? (5 years old and counting...)</p>
<p>i managed to delete WHOLE issue instead of the single comment.. :(</p> Redmine - Feature #1725: Delete button on commentshttps://www.redmine.org/issues/1725?journal_id=686632016-01-17T15:29:10ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/14993">delete-note.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/14993/delete-note.png">delete-note.png</a> added</li><li><strong>File</strong> <a href="/attachments/14994">add_a_delete_link_to_journal_entries_v2.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/14994/add_a_delete_link_to_journal_entries_v2.patch">add_a_delete_link_to_journal_entries_v2.patch</a> added</li><li><strong>Target version</strong> set to <i>3.3.0</i></li></ul><p>Updated patch for 3.2.0.devel.15067.</p>
<p>The procedure to delete note is a little bit difficult to understand. This change improve usability. In addition, we can avoid accidental deletion of a issue by clicking delete button under a latest note.</p>
<p>Please include this feature in Redmine 3.3.0.</p>
<p><img src="https://www.redmine.org/attachments/download/14993/delete-note.png" title="screenshot" alt="screenshot" /></p> Redmine - Feature #1725: Delete button on commentshttps://www.redmine.org/issues/1725?journal_id=687662016-01-20T11:07:41ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul>Feature added in <a class="changeset" title="Adds a "Delete" button to issue notes (#1725)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/15072">r15072</a>.<br />I made slight changes to the patch:
<ul>
<li>removed image_tag regarding <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Use CSS instead of image_tag() to show icons for better theming support (Closed)" href="https://www.redmine.org/issues/21256">#21256</a></li>
<li>use of existing confirmation message</li>
<li>AJAX call (similar to how the journal edit works)</li>
</ul>
<p>Thanks.</p> Redmine - Feature #1725: Delete button on commentshttps://www.redmine.org/issues/1725?journal_id=687682016-01-20T11:46:38Zrm user
<ul></ul><p>wow! 7years old issue is finally solved!</p>
<p>big up Jean-Philippe and Go MAEDA!</p>
<p>what about permissions btw? is there a permission where user can delete only his own comments on issues?</p> Redmine - Feature #1725: Delete button on commentshttps://www.redmine.org/issues/1725?journal_id=687692016-01-20T12:04:23ZJean-Philippe Langjp_lang@yahoo.fr
<ul></ul><p>rm user wrote:</p>
<blockquote>
<p>what about permissions btw? is there a permission where user can delete only his own comments on issues?</p>
</blockquote>
<p>As noted above, users with "edit notes" or "edit own notes" were already able to delete notes by making them empty. The delete button is just some kind of shortcut for doing this. The permissions are the same, so the answer is yes, you can allow users to edit/delete only their own notes.</p>