Project

General

Profile

Actions

Defect #17581

closed

Drag & Drop does not work with Safari 5.1

Added by fred bregar over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Attachments
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

see #13932-13 - i would have re-opened but i do not have permission


Related issues

Related to Redmine - Defect #13932: File upload does not work with SafariClosed

Actions
Actions #1

Updated by Toshi MARUYAMA over 9 years ago

  • Category set to Attachments
  • Target version set to 2.4.7
Actions #2

Updated by Toshi MARUYAMA over 9 years ago

  • Related to Defect #13932: File upload does not work with Safari added
Actions #3

Updated by Etienne Massip over 9 years ago

Why remove the 'FileReader' in window test?

Actions #4

Updated by Toshi MARUYAMA over 9 years ago

Etienne Massip wrote:

Why remove the 'FileReader' in window test?

fred, could you give us the answer?

Actions #5

Updated by fred bregar over 9 years ago

FileReader is not needed. (Search repo for FileReader)

Checking for FileReader was simply a hack for Safari 5.1 to return false. FileReader is for actually reading a file in a browser (like dragging a text file into the browser and creating a <textarea> tag and displaying contents of the file). Redmine is not reading the contents of the File, just uploading it.

a better test would be:

if ($.ajaxSettings.xhr().upload && inputEl.files)
//but this instantiates a new XMLHttpRequest object and does nothing with it.

but like i said (#13932-13) the real problem is jQuery. jQuery was amazing, but unless you need to support IE8 and below there is really no need for it these days.

Actions #6

Updated by Toshi MARUYAMA over 9 years ago

  • Status changed from New to Closed
  • Resolution set to Fixed

Committed in trunk, 2.5-stable and 2.4-stable, thanks.

Actions

Also available in: Atom PDF