Defect #17757
Link with hash does not work on Firefox
Status: | Closed | Start date: | ||
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | % Done: | 0% | ||
Category: | UI | |||
Target version: | 2.6.6 | |||
Resolution: | Fixed | Affected version: | 2.5.2 |
Description
In opening this link in new web browser window,
browser goes to line 275.
source:trunk/public/help/zh-tw/wiki_syntax_detailed.html@13340#L275
IE and Chrome work fine, but Firefox 31.0 does not work.
Firefox stays on top of page.
On click in address bar, ff goes to line 275.
It seems jquery-1.8.3-ui-1.9.2-ujs-2.0.3.js problem.
Following modificaion works.
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -1295,7 +1295,8 @@ module ApplicationHelper
# Returns the javascript tags that are included in the html layout head
def javascript_heads
- tags = javascript_include_tag('jquery-1.8.3-ui-1.9.2-ujs-2.0.3', 'application')
+ # tags = javascript_include_tag('jquery-1.8.3-ui-1.9.2-ujs-2.0.3', 'application')
+ tags = ""
unless User.current.pref.warn_on_leaving_unsaved == '0'
tags << "\n".html_safe + javascript_tag("$(window).load(function(){ warnLeavingUnsaved('#{escape_javascript l(:text_warn_on_leaving_unsaved)}'); });")
end
Related issues
History
#1
Updated by Toshi MARUYAMA over 5 years ago
- Related to Feature #13134: Focus first text field automatically added
#2
Updated by Toshi MARUYAMA over 5 years ago
#13134#note-8 says the reason.
#3
Updated by Jean-Philippe Lang over 5 years ago
- Subject changed from Line link does not work on Firefox new window to Link with hash does not work on Firefox
- Status changed from New to Resolved
- Assignee set to Jean-Philippe Lang
- Target version set to 2.6.6
- Resolution set to Fixed
Fixed in r14396. Automatic focus is disabled when URL contains a hash.
#4
Updated by b b over 5 years ago
Thx for the fix :)
#5
Updated by Jean-Philippe Lang over 5 years ago
- Status changed from Resolved to Closed