Actions
Defect #18605
closed
Wrong usage of logger.info to test log level
Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
logger.info (instead of logger.info?) can trigger an error
Line 185 :
logger.info "time entry could not be updated: #{time_entry.errors.full_messages}" if logger && logger.info
replace by :
logger.info "time entry could not be updated: #{time_entry.errors.full_messages}" if logger && logger.info?
Updated by Jérôme BATAILLE about 10 years ago
Sorry I missed a closing pre Tag !
Updated by Jean-Philippe Lang about 10 years ago
- Description updated (diff)
Jérôme BATAILLE wrote:
logger.info (instead of logger.info?) can trigger an error
In which circumstances?
Updated by Jérôme BATAILLE about 10 years ago
Jean-Philippe Lang wrote:
In which circumstances?
In fact it can't because nil is managed as the default value.
But logger.info always return true (http://www.ruby-doc.org/stdlib-2.0/libdoc/logger/rdoc/Logger.html#method-i-add), so you can't use logger.info to detect if info level is enabled.
Updated by Jean-Philippe Lang about 10 years ago
- Subject changed from Typo in app/controllers/timelog_controller.rb to Wrong usage of logger.info to test log level
- Category changed from Time tracking to Code cleanup/refactoring
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
- Target version set to 3.0.0
- Resolution set to Fixed
Fixed in r13766 with another one, thanks.
Actions