Redmine

It seems awesome_nested_set does not catch MS SQL server dead lock.
https://github.com/collectiveidea/awesome_nested_set/blob/v2.1.5/lib/awesome_nested_set/awesome_nested_set.rb#L553

As I'm not really familiar with RoR, I started a clone of Redmine, went to /lib/plugins/awesome_nested_set/lib/awesome_nested_set/model/transactable.rb and edited the def in_tenacious_transaction(&block) method like this (added logging and rescue Exception instead of what was there):

     def in_tenacious_transaction(&block)

            logger = Logger.new(File.open(Rails.root.join('log/deadlock_msg.log'), 'a', sync: true))
            logger.formatter = Logger::Formatter.new
            logger.info "in transaction" 

            retry_count = 0
            begin
              transaction(&block)
            rescue Exception => error
              logger.error "exception happened" 
              logger.error "error: #{error.message}" 
              logger.error error.backtrace
              raise unless connection.open_transactions.zero?
              raise unless error.message =~ /Deadlock found when trying to get lock|Lock wait timeout exceeded|has been chosen as the deadlock victim/
              raise unless retry_count < 10
              retry_count += 1
              logger.info "Deadlock detected on retry #{retry_count}, restarting transaction" 
              sleep(rand(retry_count)*0.1) # Aloha protocol
              retry
            end
          end

What confuses me is that the only records I see in this log file are the "in transaction" ones, but no error messages which I expected to see. Still I see deadlock errors in production.log.

I created issue.
https://github.com/collectiveidea/awesome_nested_set/issues/298