https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292015-03-10T03:58:40ZRedmineRedmine - Defect #19316: CustomField#possible_values may raise undefined method `force_encoding' errorhttps://www.redmine.org/issues/19316?journal_id=620882015-03-10T03:58:40ZToshi MARUYAMA
<ul><li><strong>Target version</strong> set to <i>3.0.1</i></li></ul> Redmine - Defect #19316: CustomField#possible_values may raise undefined method `force_encoding' errorhttps://www.redmine.org/issues/19316?journal_id=620892015-03-10T04:00:16ZToshi MARUYAMA
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/62089/diff?detail_id=47069">diff</a>)</li></ul> Redmine - Defect #19316: CustomField#possible_values may raise undefined method `force_encoding' errorhttps://www.redmine.org/issues/19316?journal_id=621052015-03-10T18:07:39ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Needs feedback</i></li></ul><p>How did you get a float value in possible values? If #possible_values returns non string values, it won't work with regular list custom fields. So the proper fix should rather be:</p>
<pre><code class="diff syntaxhl"><span class="gh">Index: app/models/custom_field.rb
===================================================================
</span><span class="gd">--- app/models/custom_field.rb (revision 14067)
</span><span class="gi">+++ app/models/custom_field.rb (working copy)
</span><span class="p">@@ -118,7 +118,7 @@</span>
values = read_attribute(:possible_values)
if values.is_a?(Array)
values.each do |value|
<span class="gd">- value.force_encoding('UTF-8')
</span><span class="gi">+ value.to_s.force_encoding('UTF-8')
</span> end
values
else
</code></pre> Redmine - Defect #19316: CustomField#possible_values may raise undefined method `force_encoding' errorhttps://www.redmine.org/issues/19316?journal_id=621092015-03-10T19:26:51ZDmitry Repkin
<ul></ul><p>Jean-Philippe Lang wrote:</p>
<blockquote>
<p>How did you get a float value in possible values? If #possible_values returns non string values, it won't work with regular list custom fields.</p>
</blockquote>
<p>So it stops working in 3.0; even 'Issues' list stops to show. It seems it is a 'Affected versions' custom field, which contains '1.0' element in list.</p>
<p>I've checked 'to_s' patch, all works fine.</p> Redmine - Defect #19316: CustomField#possible_values may raise undefined method `force_encoding' errorhttps://www.redmine.org/issues/19316?journal_id=622382015-03-14T08:25:40ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Subject</strong> changed from <i>Problem with 'force_encoding'</i> to <i>CustomField#possible_values may raise undefined method `force_encoding' error</i></li><li><strong>Status</strong> changed from <i>Needs feedback</i> to <i>Resolved</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>This should be fixed in <a class="changeset" title="CustomField#possible_values may raise undefined method `force_encoding' error (#19316)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/14079">r14079</a>, thanks for the feedback.</p> Redmine - Defect #19316: CustomField#possible_values may raise undefined method `force_encoding' errorhttps://www.redmine.org/issues/19316?journal_id=622592015-03-14T15:03:10ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>