If user using customized theme with special characters in folder name, the generated stylesheet's URL won't be valid
I report this because the special case can cause error in my plugin, redmine_issue_reminder
If user use folder named "circle space" in redmine for customized theme, the generated page can use:
<link href="/themes/circle%20space/stylesheets/application.css" media="all" rel="stylesheet" type="text/css">
<link href="/themes/circle space/stylesheets/application.css" media="all" rel="stylesheet" type="text/css">
href syntax : is it okay to have space in file name?¶
If user using customized theme with special characters in folder name, the generated stylesheet's URL is not valid
The patch only escapes String but not Symbol, so it may be not a full solution.
sh: 1: svn: not found sh: 1: darcs: not found sh: 1: cvs: not found sh: 1: bzr: not found Environment: Redmine version 2.6.3.stable Ruby version 2.0.0-p598 (2014-11-13) [x86_64-linux] Rails version 3.2.21 Environment production Database adapter Mysql2 SCM: Mercurial 2.8.2 Git 1.9.1 Filesystem Redmine plugins: clipboard_image_paste 1.9 progressive_projects_list 1.0.0 redmine_bootstrap_kit 0.1 redmine_didyoumean 1.2.0 redmine_graphs 0.1.0 redmine_image_clipboard_paste 1.0.0 redmine_issue_reminder 3.0.0 redmine_issue_templates 0.1.0 redmine_keyboard_shortcuts 0.0.1 redmine_lightbox 0.0.8 redmine_stealth 0.6.0 redmine_zenedit 0.0.2 scrum 0.9.1 sidebar_hide 0.0.7
Updated by Jethro Yu over 8 years ago
- Typo about my plugin, it's http://www.redmine.org/plugins/redmine_mail_reminder
- It Turns out the patch can cause other error. DO NOT USE THE PATCH!!
The problem is that Premailer uses URI to parse stylesheet file path, which errors when path has white space.
I have Monkey-Patched Premailer to use addressable/uri instead of native uri and it's fine now.
"My patch for Premailer/Premailer-rails"
However the issue still exists and currently there are no proper patch for this.