https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292015-06-18T09:35:05ZRedmineRedmine - Patch #20124: Query option, The sql for field to allow groups option.https://www.redmine.org/issues/20124?journal_id=642662015-06-18T09:35:05ZRupesh J
<ul></ul><p>The advantage of this patch, is that I do not need to alias the sql_for_field method in my plugin!<br />I am also open for more elegant solution.<br />Thanks.</p> Redmine - Patch #20124: Query option, The sql for field to allow groups option.https://www.redmine.org/issues/20124?journal_id=693082016-02-18T04:40:56ZToshi MARUYAMA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Needs feedback</i></li></ul><p>Where is <code>$2</code> from?<br /><code>field =~ /^(.+)\./</code> returns only <code>$1</code>.</p> Redmine - Patch #20124: Query option, The sql for field to allow groups option.https://www.redmine.org/issues/20124?journal_id=693102016-02-18T10:35:02ZRupesh J
<ul></ul><p>For the below cases, With grouping of filters,</p>
<p>Suppose, If I add a custom filter through a plugin patch <br /><pre><code class="ruby syntaxhl"> <span class="n">add_available_filter</span><span class="p">(</span><span class="s2">"question.qassigned_to_id"</span><span class="p">,</span> <span class="ss">:type</span> <span class="o">=></span> <span class="ss">:list</span><span class="p">,</span> <span class="ss">:values</span> <span class="o">=></span> <span class="n">author_values</span><span class="p">,</span>
<span class="ss">:caption</span> <span class="o">=></span> <span class="ss">:field_question_assigned_to_id</span><span class="p">,</span> <span class="ss">:name</span> <span class="o">=></span> <span class="n">l</span><span class="p">(</span><span class="ss">:field_question_assigned_to_id_esi</span><span class="p">)</span>
<span class="p">)</span>
</code></pre></p>
<p>The only way to handle the corresponding SQL query is to alias the sql_for_field.<br />Instead if the attached patch is provided, <br />I can avoid the alias and also have my method,</p>
<pre><code class="ruby syntaxhl"> <span class="k">def</span> <span class="nf">sql_for_qassigned_to_id_field</span><span class="p">(</span><span class="o">.....</span><span class="p">)</span>
<span class="o">...</span><span class="p">.</span> <span class="nf">sql</span> <span class="n">logic</span><span class="o">...</span>
<span class="k">end</span>
</code></pre>
<p>Thank You.</p> Redmine - Patch #20124: Query option, The sql for field to allow groups option.https://www.redmine.org/issues/20124?journal_id=693142016-02-18T11:27:40ZToshi MARUYAMA
<ul></ul><p>In your <a class="attachment" href="https://www.redmine.org/attachments/13804">sql_for_fields_with_group-git.diff</a></p>
<pre><code class="ruby syntaxhl"> <span class="k">elsif</span> <span class="n">field</span> <span class="o">=~</span> <span class="sr">/^(.+)\./</span> <span class="o">&&</span> <span class="nb">respond_to?</span><span class="p">(</span><span class="s2">"sql_for_</span><span class="si">#{</span><span class="vg">$2</span><span class="si">}</span><span class="s2">_field"</span><span class="p">)</span>
<span class="c1"># specific statement</span>
<span class="n">filters_clauses</span> <span class="o"><<</span> <span class="nb">send</span><span class="p">(</span><span class="s2">"sql_for_</span><span class="si">#{</span><span class="vg">$2</span><span class="si">}</span><span class="s2">_field"</span><span class="p">,</span> <span class="n">field</span><span class="p">,</span> <span class="n">operator</span><span class="p">,</span> <span class="n">v</span><span class="p">)</span>
</code></pre>
<p><a class="external" href="http://ruby-doc.org/core-2.1.1/Regexp.html#class-Regexp-label-Special+global+variables">http://ruby-doc.org/core-2.1.1/Regexp.html#class-Regexp-label-Special+global+variables</a></p>
<blockquote>
<p>$1, $2 and so on contain text matching first, second, etc capture group;</p>
</blockquote>
<p>But your <code>field =~ /^(.+)\./</code> has only one parenthesis.</p> Redmine - Patch #20124: Query option, The sql for field to allow groups option.https://www.redmine.org/issues/20124?journal_id=693182016-02-18T14:13:53ZRupesh J
<ul><li><strong>File</strong> <a href="/attachments/15456">sql_for_fields_with_group-git-updated.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/15456/sql_for_fields_with_group-git-updated.patch">sql_for_fields_with_group-git-updated.patch</a> added</li></ul><p>Yes, Realized my mistake. Thank You.<br />Here is the Updated patch.</p>
<p>Thanks.</p> Redmine - Patch #20124: Query option, The sql for field to allow groups option.https://www.redmine.org/issues/20124?journal_id=693192016-02-18T14:17:46ZToshi MARUYAMA
<ul><li><strong>Status</strong> changed from <i>Needs feedback</i> to <i>New</i></li></ul>