Patch #20507
ThemesHelper reopening ApplicationHelper is problem with autoloading
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Jean-Philippe Lang | % Done: | 0% | |
| Category: | Code cleanup/refactoring | |||
| Target version: | 3.2.0 |
Description
redmine/themes.rb defines ApplicationHelper, but it gets into problems, if there is a patch for it in plugin, which redefines ApplicationHelper method. Rails do not load it - it is loaded, but does not have the method defined. It works only if patch is after a controller invocation, because it load it by path and do not care if it is defined. But it bassically defines the model and avoiding Rails autoloading.
themes_helper.patch 
(495 Bytes)
Associated revisions
ThemesHelper reopening ApplicationHelper is problem with autoloading (#20507).
Patch by Ondřej Ezr.
Don't reopen ApplicationHelper (#20507).
History
#1
Updated by Jean-Philippe Lang over 7 years ago
- Category set to Code cleanup/refactoring
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
- Target version set to 3.2.0
Patch committed in r14511, thanks.
#2
Updated by Jean-Philippe Lang over 7 years ago
- Status changed from Closed to Reopened
Tests broken, patch reverted:
http://www.redmine.org/builds/logs/build_trunk_postgresql_ruby-2.2_2567.html
#3
Updated by Jean-Philippe Lang about 7 years ago
- Status changed from Reopened to Closed