Project

General

Profile

Actions

Patch #20507

closed

ThemesHelper reopening ApplicationHelper is problem with autoloading

Added by Ondřej Ezr over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

redmine/themes.rb defines ApplicationHelper, but it gets into problems, if there is a patch for it in plugin, which redefines ApplicationHelper method. Rails do not load it - it is loaded, but does not have the method defined. It works only if patch is after a controller invocation, because it load it by path and do not care if it is defined. But it bassically defines the model and avoiding Rails autoloading.


Files

themes_helper.patch (495 Bytes) themes_helper.patch Ondřej Ezr, 2015-08-11 01:58
Actions #1

Updated by Jean-Philippe Lang over 8 years ago

  • Category set to Code cleanup/refactoring
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Target version set to 3.2.0

Patch committed in r14511, thanks.

Actions #2

Updated by Jean-Philippe Lang over 8 years ago

  • Status changed from Closed to Reopened
Actions #3

Updated by Jean-Philippe Lang over 8 years ago

  • Status changed from Reopened to Closed
Actions

Also available in: Atom PDF