Project

General

Profile

Actions

Defect #21069

closed

Hard-coded label for hour

Added by Fabrice ROBIN over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Category:
Issues
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

The commit r14273, which has been merged into the 3.1 branch, introduced an error as a "h" label is hard-coded in the function l_hours_short:

"%.2f h" % hours.to_f

This label should be translated through i18n. Asian users will surely report this anomaly.

Actions #1

Updated by Fabrice ROBIN over 8 years ago

see Defect #17550

Actions #2

Updated by Toshi MARUYAMA over 8 years ago

  • Description updated (diff)
Actions #3

Updated by Toshi MARUYAMA over 8 years ago

  • Target version set to 3.2.0
Actions #4

Updated by Jean-Philippe Lang over 8 years ago

  • Subject changed from hard-coded label for hour to Hard-coded label for hour
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Translation string added in r14759.

Actions #5

Updated by Daniel Ritz over 8 years ago

Errm...it's now showing stuff like "2.5 h h":

     def l_hours_short(hours)
-      "%.2f h" % hours.to_f
+      l(:label_f_hour_short, :value => ("%.2f h" % hours.to_f))
     end

i.e. the format string still contains the " h"...
Actions #6

Updated by Toshi MARUYAMA over 8 years ago

  • Status changed from Closed to Reopened
Actions #7

Updated by Jean-Philippe Lang over 8 years ago

  • Status changed from Reopened to Closed

Fixed.

Actions

Also available in: Atom PDF