https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292016-07-29T05:45:17ZRedmineRedmine - Patch #23378: Speedup Project Settings with many membershttps://www.redmine.org/issues/23378?journal_id=724762016-07-29T05:45:17ZGo MAEDA
<ul></ul><p>Interesting. Reducing 12 sec to 0.6 sec is big improvement. How many members on the project?</p>
<p>Here is a diff made from the first post.</p>
<pre><code class="diff syntaxhl"><span class="gh">Index: app/views/projects/settings/_members.html.erb
===================================================================
</span><span class="gd">--- app/views/projects/settings/_members.html.erb (revision 15732)
</span><span class="gi">+++ app/views/projects/settings/_members.html.erb (working copy)
</span><span class="p">@@ -1,5 +1,5 @@</span>
<% roles = Role.find_all_givable
<span class="gd">- members = @project.memberships.active.includes(:member_roles, :roles, :principal).to_a.sort %>
</span><span class="gi">+ members = @project.memberships.active.includes(:member_roles, :roles, :principal).order('roles.builtin, roles.position, users.firstname, users.lastname')
</span>
<p><%= link_to l(:label_member_new), new_project_membership_path(@project), :remote => true, :class => "icon icon-add" %></p>
</code></pre> Redmine - Patch #23378: Speedup Project Settings with many membershttps://www.redmine.org/issues/23378?journal_id=724812016-07-29T12:09:06ZVictor Campos
<ul></ul><p>6K members</p> Redmine - Patch #23378: Speedup Project Settings with many membershttps://www.redmine.org/issues/23378?journal_id=727042016-08-18T04:37:57ZToshi MARUYAMA
<ul></ul><p>I think SQL "users.firstname, users.lastname" order is not acceptable because AFAIK user sort is configurable.<br /><a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/tags/3.3.0/app/models/user.rb#L24">source:tags/3.3.0/app/models/user.rb#L24</a></p> Redmine - Patch #23378: Speedup Project Settings with many membershttps://www.redmine.org/issues/23378?journal_id=1123542024-01-20T08:59:33ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li></ul><p>Closing this issue for the reason described in <a href="#note-3">#note-3</a>.</p> Redmine - Patch #23378: Speedup Project Settings with many membershttps://www.redmine.org/issues/23378?journal_id=1123582024-01-20T12:23:12ZHolger Just
<ul></ul><p>This was already fixed in Redmine <a class="version" href="https://www.redmine.org/versions/119">3.4.0</a> with <a class="changeset" title="Sort members on the DB side." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/16040">r16040</a> by using <code>Principal.fields_for_order_statement</code></p>