Project

General

Profile

Actions

Defect #2422

closed

functional test error - RepositoriesController / test_committers

Added by yves dufour almost 16 years ago. Updated almost 16 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
2008-12-31
Due date:
% Done:

0%

Estimated time:
Resolution:
Invalid
Affected version:

Description

in this test , we add a commit with an unknown user... :committer => 'foo'
running the test leads to an error :
ActiveRecord::RecordNotFound: Couldn't find User with ID=0

u d += User.find(additional_user_ids) unless additional_user_ids.empty?

additional_user_ids is not empty .. (contains 0) and we got the error..

could override it with :

u d += User.find(additional_user_ids) unless additional_user_ids.empty? || additional_user_ids.include?(0)

but not sure it's fine...

Actions #1

Updated by Jean-Philippe Lang almost 16 years ago

  • Status changed from New to Closed
  • Resolution set to Invalid

u d += User.find(additional_user_ids) unless additional_user_ids.empty?

I don't see this code anywhere in the app.

Actions

Also available in: Atom PDF