https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292017-01-10T10:25:10ZRedmineRedmine - Defect #24617: Browser js/css cache remains after upgradehttps://www.redmine.org/issues/24617?journal_id=758012017-01-10T10:25:10ZToshi MARUYAMA
<ul></ul><p>Good Job!!<br />Is it related that Redmine does not use asset pipeline?</p> Redmine - Defect #24617: Browser js/css cache remains after upgradehttps://www.redmine.org/issues/24617?journal_id=761722017-01-20T18:56:32Zluigifab !
<ul></ul><p>+1 Very good patch.</p> Redmine - Defect #24617: Browser js/css cache remains after upgradehttps://www.redmine.org/issues/24617?journal_id=765832017-02-11T13:30:25ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>3.4.0</i></li></ul> Redmine - Defect #24617: Browser js/css cache remains after upgradehttps://www.redmine.org/issues/24617?journal_id=766042017-02-12T10:05:09ZAkipii Oga
<ul></ul><p>+1<br />When upgrading Redmine(2.x→3.x), the screen may collapse.<br />If you fix with this patch, I want you to merge quickly.</p> Redmine - Defect #24617: Browser js/css cache remains after upgradehttps://www.redmine.org/issues/24617?journal_id=766382017-02-13T14:14:24ZToshi MARUYAMA
<ul></ul><p>Toshi MARUYAMA wrote:</p>
<blockquote>
<p>Good Job!!<br />Is it related that Redmine does not use asset pipeline?</p>
</blockquote>
<p>Ref: <a class="issue tracker-3 status-1 priority-4 priority-default" title="Patch: Reduce coupling between plugins and the "plugins/" directory (New)" href="https://www.redmine.org/issues/13927#note-2">#13927#note-2</a></p> Redmine - Defect #24617: Browser js/css cache remains after upgradehttps://www.redmine.org/issues/24617?journal_id=766472017-02-14T01:52:10ZPavel Rosický
<ul></ul><p><a class="user active" href="https://www.redmine.org/users/10651">toshio harita</a> - why is the asset pipeline disabled?</p>
<p>btw. suffixes like "filename <strong>?1481777729</strong> " are just ignored and still cached by some web-servers.</p>
<p><a class="external" href="http://guides.rubyonrails.org/asset_pipeline.html">http://guides.rubyonrails.org/asset_pipeline.html</a> - using a file digest is safer then using timestamps<br />ex. <a class="external" href="https://redmine.org/assets/myasset-">https://redmine.org/assets/myasset-</a> <strong>66ca44f5c66abebe01f39e780e5b89159a04e7019c4515792224dd4cae962bbc</strong> .js</p> Redmine - Defect #24617: Browser js/css cache remains after upgradehttps://www.redmine.org/issues/24617?journal_id=766482017-02-14T02:07:51ZToshi MARUYAMA
<ul></ul><p>Pavel Rosický wrote:</p>
<blockquote>
<p><a class="user active" href="https://www.redmine.org/users/10651">toshio harita</a> - why is the asset pipeline disabled?</p>
</blockquote>
<p>As <a class="issue tracker-3 status-1 priority-4 priority-default" title="Patch: Reduce coupling between plugins and the "plugins/" directory (New)" href="https://www.redmine.org/issues/13927#note-3">#13927#note-3</a>, we don't know how to <strong>port</strong> asset in plugins.</p> Redmine - Defect #24617: Browser js/css cache remains after upgradehttps://www.redmine.org/issues/24617?journal_id=767822017-02-20T03:23:33ZKohei Nakamura
<ul></ul><a name="1-Great-Job"></a>
<h2 >+1 Great Job!<a href="#1-Great-Job" class="wiki-anchor">¶</a></h2>
<p>I was also upgrading to Redmine 2.5.1 to 3.3.2, Redmine layout collapsed!<br />I did not understand the cause and attempted to cancel the version upgrade.</p>
<p>However, <strong>Go MAEDA</strong> taught me this patch,</p>
<p>Upgrade succeeded.</p>
<p>I would like to apply the patch so that nobody suffers from this problem.</p>
<hr />
<p>In my case, I applied this patch by the following procedure. <br />(Redmine 3.3.2)</p>
<pre>
#cd redmine/config/initilizers
#wget http://www.redmine.org/attachments/download/17275/0001-Adds-asset_id-parameters-to-assets.patch
#patch -u < 0001-Adds-asset_id-parameters-to-assets.
and input redmine/config/initializers/10-patches.rb
#bundle exec rake tmp:cache:clear tmp:sessions:clear
Apache restart(Redmine Restart).
</pre>
<pre>
View source in the browser and confirm that it has a parameter string.
(ex. ***.js.?1486805824)
</pre> Redmine - Defect #24617: Browser js/css cache remains after upgradehttps://www.redmine.org/issues/24617?journal_id=772002017-03-09T11:15:08ZMarius BĂLTEANU
<ul></ul><p>I didn't test the patch, but the functionality is really needed. Currently, we use a workaround with a pagespeed module for nginx in order to purge the cache after a release with js/css changes.</p> Redmine - Defect #24617: Browser js/css cache remains after upgradehttps://www.redmine.org/issues/24617?journal_id=776832017-04-03T05:50:03ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Patch committed, thanks.</p> Redmine - Defect #24617: Browser js/css cache remains after upgradehttps://www.redmine.org/issues/24617?journal_id=778932017-04-09T05:25:33ZGo MAEDA
<ul><li><strong>Category</strong> set to <i>UI</i></li></ul><p>Since the problem adversely affects web UI, I am setting category field to "UI".</p> Redmine - Defect #24617: Browser js/css cache remains after upgradehttps://www.redmine.org/issues/24617?journal_id=798112017-07-06T15:25:58ZGreg T
<ul></ul><p>This patch doesn't seem to effect <code>@import url(../../../stylesheets/application.css);</code> in themes, so I still have to add a Cache-Control header.</p>
<pre>
<IfModule mod_deflate.c>
# DeflateAlterETag NoChange
RequestHeader edit "If-None-Match" '^"((.*)-gzip)"$' '"$1", "$2"'
</IfModule>
<filesMatch "application\.css$">
<ifModule mod_headers.c>
Header set Cache-Control "max-age=60, must-revalidate"
</ifModule>
</filesMatch>
</pre> Redmine - Defect #24617: Browser js/css cache remains after upgradehttps://www.redmine.org/issues/24617?journal_id=873992018-09-17T23:28:52ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-1 priority-4 priority-default" href="/issues/29625">Defect #29625</a>: application.css imported by themes not covered by cache control versioning</i> added</li></ul>