https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292017-02-15T08:58:16ZRedmineRedmine - Defect #25077: Issue description filter's 'none' operator does not match issues with blank descriptionshttps://www.redmine.org/issues/25077?journal_id=766752017-02-15T08:58:16ZMischa The Evil
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/1159">Feature #1159</a>: Allow issue description to be searchable as a filter</i> added</li></ul> Redmine - Defect #25077: Issue description filter's 'none' operator does not match issues with blank descriptionshttps://www.redmine.org/issues/25077?journal_id=767582017-02-18T19:20:29ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/17772">set_blank_decriptions_to_nil.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/17772/set_blank_decriptions_to_nil.patch">set_blank_decriptions_to_nil.patch</a> added</li></ul><p>From my point of view, there are 2 ways to fix this issue:</p>
<p>1. Set description to nil for all new issues with blank description and migrate all existing issues that have description blank to nil.<br />2. Change the query for description field in order to check for description is nil or description equals with empty string;</p>
<p>I made a patch that implements the first solution because I think in this way we fix the root cause. The second solution is just an workaround.</p>
<p>If there is any side effect of my solution, I can make a patch with the second fix.</p> Redmine - Defect #25077: Issue description filter's 'none' operator does not match issues with blank descriptionshttps://www.redmine.org/issues/25077?journal_id=768702017-02-22T22:34:44ZMarius BĂLTEANU
<ul></ul><p>Mischa The Evil, do you have any feedback regarding the patch? I'm thinking now that if setting the description blank instead of null is a rails behaviour, we should not change this and I should create a patch with the second solution.</p> Redmine - Defect #25077: Issue description filter's 'none' operator does not match issues with blank descriptionshttps://www.redmine.org/issues/25077?journal_id=771142017-03-05T09:38:27ZMarius BĂLTEANU
<ul></ul><p>Jean-Philippe Lang, how do you think we should solve this issue? With the solution from my patch or we should modify the query?</p> Redmine - Defect #25077: Issue description filter's 'none' operator does not match issues with blank descriptionshttps://www.redmine.org/issues/25077?journal_id=771152017-03-05T15:43:27ZJean-Philippe Langjp_lang@yahoo.fr
<ul></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>Jean-Philippe Lang, how do you think we should solve this issue? With the solution from my patch or we should modify the query?</p>
</blockquote>
<p>We should be able to modify the query for text/string filters without much trouble.</p> Redmine - Defect #25077: Issue description filter's 'none' operator does not match issues with blank descriptionshttps://www.redmine.org/issues/25077?journal_id=771252017-03-06T07:38:31ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/17863">rm_25077_fix_query_filter_after_none_for_text_and_string_column.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/17863/rm_25077_fix_query_filter_after_none_for_text_and_string_column.patch">rm_25077_fix_query_filter_after_none_for_text_and_string_column.patch</a> added</li></ul><p>Thanks for your feedback, Jean-Philippe Lang. I've attached a new patch that fixes the issue for text (like description) and string fields. For custom fields, the issue was already fixed.</p> Redmine - Defect #25077: Issue description filter's 'none' operator does not match issues with blank descriptionshttps://www.redmine.org/issues/25077?journal_id=771282017-03-06T09:45:08ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>3.4.0</i></li></ul> Redmine - Defect #25077: Issue description filter's 'none' operator does not match issues with blank descriptionshttps://www.redmine.org/issues/25077?journal_id=771682017-03-07T17:51:47ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Thanks Marius, the patch is committed.</p> Redmine - Defect #25077: Issue description filter's 'none' operator does not match issues with blank descriptionshttps://www.redmine.org/issues/25077?journal_id=794262017-06-23T14:56:53ZPavel Rosický
<ul></ul><p>it should also be fixed on '*' operator like on custom values, don't you think?</p> Redmine - Defect #25077: Issue description filter's 'none' operator does not match issues with blank descriptionshttps://www.redmine.org/issues/25077?journal_id=795932017-06-29T19:57:04ZMarius BĂLTEANU
<ul></ul><p>Pavel Rosický wrote:</p>
<blockquote>
<p>it should also be fixed on '*' operator like on custom values, don't you think?</p>
</blockquote>
<p>Can you open a new issue, please?</p> Redmine - Defect #25077: Issue description filter's 'none' operator does not match issues with blank descriptionshttps://www.redmine.org/issues/25077?journal_id=1121242024-01-01T04:44:58ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/39991">Defect #39991</a>: Fix "any" operator for text filters to exclude empty text values</i> added</li></ul>