https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292017-07-15T11:58:46ZRedmineRedmine - Defect #26445: Text formatting not applied to commit messages even if enabled in settingshttps://www.redmine.org/issues/26445?journal_id=800502017-07-15T11:58:46ZNils Grimm
<ul></ul><p>Or other way around would make sense.<br />If the system setting is set to false, the text would still be formatted.<br /><pre><code class="ruby syntaxhl"> <span class="k">if</span> <span class="n">options</span><span class="p">[</span><span class="ss">:formatting</span><span class="p">]</span> <span class="o">==</span> <span class="kp">false</span>
<span class="n">text</span> <span class="o">=</span> <span class="n">h</span><span class="p">(</span><span class="n">text</span><span class="p">)</span>
<span class="k">else</span>
<span class="n">formatting</span> <span class="o">=</span> <span class="no">Setting</span><span class="p">.</span><span class="nf">text_formatting</span> <span class="o">||</span> <span class="n">options</span><span class="p">[</span><span class="ss">:formatting</span><span class="p">]</span>
<span class="n">text</span> <span class="o">=</span> <span class="no">Redmine</span><span class="o">::</span><span class="no">WikiFormatting</span><span class="p">.</span><span class="nf">to_html</span><span class="p">(</span><span class="n">formatting</span><span class="p">,</span> <span class="n">text</span><span class="p">,</span> <span class="ss">:object</span> <span class="o">=></span> <span class="n">obj</span><span class="p">,</span> <span class="ss">:attribute</span> <span class="o">=></span> <span class="kp">attr</span><span class="p">)</span>
<span class="k">end</span>
</code></pre></p> Redmine - Defect #26445: Text formatting not applied to commit messages even if enabled in settingshttps://www.redmine.org/issues/26445?journal_id=800512017-07-15T12:14:12ZToshi MARUYAMA
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/80051/diff?detail_id=63036">diff</a>)</li></ul> Redmine - Defect #26445: Text formatting not applied to commit messages even if enabled in settingshttps://www.redmine.org/issues/26445?journal_id=800522017-07-15T12:19:14ZToshi MARUYAMA
<ul><li><strong>Target version</strong> set to <i>3.4.2</i></li></ul> Redmine - Defect #26445: Text formatting not applied to commit messages even if enabled in settingshttps://www.redmine.org/issues/26445?journal_id=800532017-07-15T12:27:26ZToshi MARUYAMA
<ul></ul><p>Nils Grimm wrote:</p>
<blockquote>
<p>Or other way around would make sense.<br />If the system setting is set to false, the text would still be formatted.<br />[...]</p>
</blockquote>
<p>I think your description is good enough because "format = true/false" is non sense.</p> Redmine - Defect #26445: Text formatting not applied to commit messages even if enabled in settingshttps://www.redmine.org/issues/26445?journal_id=800762017-07-16T18:05:05ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Subject</strong> changed from <i>Textile rendering for commit messages doesn't render textile</i> to <i>Text formatting not applied to commit messages even if enabled in settings</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Fix committed, thanks for pointing this out.</p>