https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292017-07-27T23:25:15ZRedmineRedmine - Feature #26552: Allow "max-height", "max-width", "min-height" and "min-width" CSS properties in Textilehttps://www.redmine.org/issues/26552?journal_id=803352017-07-27T23:25:15ZGo MAEDA
<ul><li><strong>Tracker</strong> changed from <i>Defect</i> to <i>Feature</i></li><li><strong>Subject</strong> changed from <i>"max-width" is not a valid CSS style</i> to <i>Allow "max-width" in Textile formatting</i></li><li><strong>Category</strong> set to <i>Text formatting</i></li></ul> Redmine - Feature #26552: Allow "max-height", "max-width", "min-height" and "min-width" CSS properties in Textilehttps://www.redmine.org/issues/26552?journal_id=828562018-01-02T11:58:20ZMichael Gerz
<ul></ul><p>I suggest applying this patch (that's why I wrote it).</p> Redmine - Feature #26552: Allow "max-height", "max-width", "min-height" and "min-width" CSS properties in Textilehttps://www.redmine.org/issues/26552?journal_id=828592018-01-02T14:48:52ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/19813">max-width-patch-v2.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/19813/max-width-patch-v2.diff">max-width-patch-v2.diff</a> added</li></ul><p>Thank you for suggesting the improvement.</p>
<p>I almost agree with you, "max-width" property is beneficial. But I think "max-height" should be available as well. Probably users believe they can also use "max-height" if Redmine supports "max-width". I have slightly modified your patch to support "max-height".</p> Redmine - Feature #26552: Allow "max-height", "max-width", "min-height" and "min-width" CSS properties in Textilehttps://www.redmine.org/issues/26552?journal_id=828602018-01-02T14:53:38ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>4.1.0</i></li></ul><p>Setting target version to 4.1.0.</p> Redmine - Feature #26552: Allow "max-height", "max-width", "min-height" and "min-width" CSS properties in Textilehttps://www.redmine.org/issues/26552?journal_id=829512018-01-08T01:29:07ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/19834">max-width-patch-v3.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/19834/max-width-patch-v3.diff">max-width-patch-v3.diff</a> added</li><li><strong>Subject</strong> changed from <i>Allow "max-width" in Textile formatting</i> to <i>Allow min-width/min-height/max-width/max-height property in Textile</i></li></ul><p>Updated the patch to support min-width and min-height. Now the patch supports properties as follows:</p>
<ul>
<li>min-width</li>
<li>min-height</li>
<li>max-width</li>
<li>max-height</li>
</ul> Redmine - Feature #26552: Allow "max-height", "max-width", "min-height" and "min-width" CSS properties in Textilehttps://www.redmine.org/issues/26552?journal_id=830172018-01-10T03:28:27ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/19858">max-width-patch-v4.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/19858/max-width-patch-v4.diff">max-width-patch-v4.diff</a> added</li></ul><p>Added tests to the patch.</p> Redmine - Feature #26552: Allow "max-height", "max-width", "min-height" and "min-width" CSS properties in Textilehttps://www.redmine.org/issues/26552?journal_id=830402018-01-11T01:36:58ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Allow min-width/min-height/max-width/max-height property in Textile</i> to <i>Allow "max-height", "max-width", "min-height" and "min-width" CSS properties in Textile</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Target version</strong> changed from <i>4.1.0</i> to <i>4.0.0</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed. Thank you for suggesting this improvement and sharing your patch.</p> Redmine - Feature #26552: Allow "max-height", "max-width", "min-height" and "min-width" CSS properties in Textilehttps://www.redmine.org/issues/26552?journal_id=830482018-01-11T10:39:37ZMarius BÄ‚LTEANU
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>Added tests to the patch.</p>
</blockquote>
<p>I would suggest to add the same two tests also for max-height and height.</p> Redmine - Feature #26552: Allow "max-height", "max-width", "min-height" and "min-width" CSS properties in Textilehttps://www.redmine.org/issues/26552?journal_id=830532018-01-11T13:10:32ZMischa The Evil
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>Go MAEDA wrote:</p>
<blockquote>
<p>Added tests to the patch.</p>
</blockquote>
<p>I would suggest to add the same two tests also for max-height and height.</p>
</blockquote>
<p>I agree.</p> Redmine - Feature #26552: Allow "max-height", "max-width", "min-height" and "min-width" CSS properties in Textilehttps://www.redmine.org/issues/26552?journal_id=830542018-01-11T13:22:23ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/19870">26552-test-height.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/19870/26552-test-height.diff">26552-test-height.diff</a> added</li></ul><p>Marius and Mischa, thank you for pointing it out. Here is a patch to add tests for "height" and "max-height".</p> Redmine - Feature #26552: Allow "max-height", "max-width", "min-height" and "min-width" CSS properties in Textilehttps://www.redmine.org/issues/26552?journal_id=830592018-01-12T02:40:39ZMarius BÄ‚LTEANU
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>Marius and Mischa, thank you for pointing it out. Here is a patch to add tests for "height" and "max-height".</p>
</blockquote>
<p>Looks good to me.</p> Redmine - Feature #26552: Allow "max-height", "max-width", "min-height" and "min-width" CSS properties in Textilehttps://www.redmine.org/issues/26552?journal_id=830772018-01-13T00:34:51ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul><p>Committed tests for "height" and "max-height" in <a class="changeset" title="Add tests for "height" and "max-height" (#26552)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/17175">r17175</a>.</p> Redmine - Feature #26552: Allow "max-height", "max-width", "min-height" and "min-width" CSS properties in Textilehttps://www.redmine.org/issues/26552?journal_id=1090232023-01-09T08:22:48ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/38073">Defect #38073</a>: CommonMark Markdown formatter does not support min-width, max-width, min-height, and max-height CSS properties</i> added</li></ul>