https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292017-09-24T11:46:52ZRedmineRedmine - Defect #26892: Link to user in wiki syntax only works when login is written in lower casehttps://www.redmine.org/issues/26892?journal_id=812562017-09-24T11:46:52ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/4179">Feature #4179</a>: Link to user in wiki syntax</i> added</li></ul> Redmine - Defect #26892: Link to user in wiki syntax only works when login is written in lower casehttps://www.redmine.org/issues/26892?journal_id=814912017-10-11T15:24:06ZToshi MARUYAMA
<ul><li><strong>Target version</strong> set to <i>4.1.0</i></li></ul> Redmine - Defect #26892: Link to user in wiki syntax only works when login is written in lower casehttps://www.redmine.org/issues/26892?journal_id=844212018-04-08T07:37:48ZMarius BĂLTEANU
<ul><li><strong>Blocked by</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/26443">Defect #26443</a>: User link syntax (user:login) doesn't work for logins consisting of an email adress</i> added</li></ul> Redmine - Defect #26892: Link to user in wiki syntax only works when login is written in lower casehttps://www.redmine.org/issues/26892?journal_id=844222018-04-08T07:38:24ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/20435">0001-user-link-syntax-should-work-also-with-logins-in-upp.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/20435/0001-user-link-syntax-should-work-also-with-logins-in-upp.patch">0001-user-link-syntax-should-work-also-with-logins-in-upp.patch</a> added</li></ul><p>Attached is a patch that fixes this issue and it should be applied after <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: User link syntax (user:login) doesn't work for logins consisting of an email adress (Closed)" href="https://www.redmine.org/issues/26443">#26443</a>.</p> Redmine - Defect #26892: Link to user in wiki syntax only works when login is written in lower casehttps://www.redmine.org/issues/26892?journal_id=844232018-04-08T07:39:45ZMarius BĂLTEANU
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Confirmed</i></li></ul> Redmine - Defect #26892: Link to user in wiki syntax only works when login is written in lower casehttps://www.redmine.org/issues/26892?journal_id=855942018-06-17T05:56:09ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Assignee</strong> set to <i>Marius BĂLTEANU</i></li></ul><p>Marius, I have applied <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: User link syntax (user:login) doesn't work for logins consisting of an email adress (Closed)" href="https://www.redmine.org/issues/26443">#26443</a> and I'm getting a failure for the test included in this patch:</p>
<pre>
Failure:
ApplicationHelperTest#test_redmine_links [test/helpers/application_helper_test.rb:406]:
user:JSMITH failed.
Expected: "<p><a class=\"user active\" href=\"/users/2\">John Smith</a></p>"
Actual: "<p>user:JSMITH</p>"
</pre>
<p>Can you have a look please?</p> Redmine - Defect #26892: Link to user in wiki syntax only works when login is written in lower casehttps://www.redmine.org/issues/26892?journal_id=856042018-06-17T14:28:19ZGo MAEDA
<ul></ul><p>Jean-Philippe Lang wrote:</p>
<blockquote>
<p>Marius, I have applied <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: User link syntax (user:login) doesn't work for logins consisting of an email adress (Closed)" href="https://www.redmine.org/issues/26443">#26443</a> and I'm getting a failure for the test included in this patch:</p>
</blockquote>
<p>This is a workaround for the error.</p>
<pre><code class="diff syntaxhl"><span class="gh">Index: app/helpers/application_helper.rb
===================================================================
</span><span class="gd">--- app/helpers/application_helper.rb (revision 17395)
</span><span class="gi">+++ app/helpers/application_helper.rb (working copy)
</span><span class="p">@@ -975,12 +975,12 @@</span>
link = link_to_project(p, {:only_path => only_path}, :class => 'project')
end
when 'user'
<span class="gd">- u = User.visible.where(:login => name, :type => 'User').first
</span><span class="gi">+ u = User.visible.where("LOWER(login) = :s AND type = 'User'", :s => name.downcase).first
</span> link = link_to_user(u, :only_path => only_path) if u
end
elsif sep == "@"
name = remove_double_quotes(identifier)
<span class="gd">- u = User.visible.where(:login => name, :type => 'User').first
</span><span class="gi">+ u = User.visible.where("LOWER(login) = :s AND type = 'User'", :s => name.downcase).first
</span> link = link_to_user(u, :only_path => only_path) if u
end
end
</code></pre> Redmine - Defect #26892: Link to user in wiki syntax only works when login is written in lower casehttps://www.redmine.org/issues/26892?journal_id=856162018-06-17T19:15:58ZMarius BĂLTEANU
<ul><li><strong>Assignee</strong> deleted (<del><i>Marius BĂLTEANU</i></del>)</li><li><strong>Target version</strong> changed from <i>4.1.0</i> to <i>4.0.0</i></li></ul><p>I agree with the workaround posted above by Go Maeda, it is enough to fix the failing test. It seems that on my local environment, the search is case insensitive and the test doesn't fail.</p> Redmine - Defect #26892: Link to user in wiki syntax only works when login is written in lower casehttps://www.redmine.org/issues/26892?journal_id=856262018-06-18T05:33:16ZGo MAEDA
<ul><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li></ul> Redmine - Defect #26892: Link to user in wiki syntax only works when login is written in lower casehttps://www.redmine.org/issues/26892?journal_id=875182018-09-23T14:55:48ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Confirmed</i> to <i>Closed</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed, thanks.</p> Redmine - Defect #26892: Link to user in wiki syntax only works when login is written in lower casehttps://www.redmine.org/issues/26892?journal_id=948432019-11-09T16:40:23ZMischa The Evil
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/32382">Defect #32382</a>: Unreliable User mention feature with PostgreSQL</i> added</li></ul> Redmine - Defect #26892: Link to user in wiki syntax only works when login is written in lower casehttps://www.redmine.org/issues/26892?journal_id=972552020-04-14T03:26:42ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> deleted (<i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/32382">Defect #32382</a>: Unreliable User mention feature with PostgreSQL</i>)</li></ul> Redmine - Defect #26892: Link to user in wiki syntax only works when login is written in lower casehttps://www.redmine.org/issues/26892?journal_id=972572020-04-14T03:26:57ZMarius BĂLTEANU
<ul><li><strong>Has duplicate</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/32382">Defect #32382</a>: Unreliable User mention feature with PostgreSQL</i> added</li></ul>